Fix https probe after 8.9.1 revert#518
Merged
mattcolegate merged 1 commit intoRuntimeTools:masterfrom Jan 15, 2018
gibfahn:https-probe
Merged
Fix https probe after 8.9.1 revert#518mattcolegate merged 1 commit intoRuntimeTools:masterfrom gibfahn:https-probe
mattcolegate merged 1 commit intoRuntimeTools:masterfrom
gibfahn:https-probe
Conversation
As the previous change was reverted, and won't go into the 8.x release line, we only need to do this for 9.0.0 and up. Refs: nodejs/node#16660
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 58.52% 58.52%
=======================================
Files 48 48
Lines 2944 2944
=======================================
Hits 1723 1723
Misses 1221 1221
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the previous change was reverted, and won't go into the 8.x release
line, we only need to do this for 9.0.0 and up.
Refs: nodejs/node#16660
cc/ @stalleyj
This means that newer versions of appmetrics will be broken for v8.9.0 only, if that's a problem I can complicate the check.