Skip to content

RK-12380 - Added a dev container - #43

Merged
Urook merged 2 commits into
masterfrom
add-dev-container
May 24, 2022
Merged

Urook merged 2 commits into
masterfrom
add-dev-container

Conversation

@Urook

@Urook Urook commented May 17, 2022

Copy link
Copy Markdown
Contributor

Added a dev container

@Urook

Urook commented May 17, 2022 •

Copy link
Copy Markdown
Contributor Author

Github Enforcer opened Task: RK-12380

@sonariorobot sonariorobot changed the title Added a dev container RK-12380 - Added a dev container May 17, 2022

@eli-hatamov-dt eli-hatamov-dt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Dockerfile overrides the devcontainer.json? cause it seems like there are different values for the same arguments in those files. For example INSTALL_MAVEN and INSTALL GRADLE have true in devcontainer.json but false in the Dockerfile (it's confusing)

@Urook

Urook commented May 18, 2022

Copy link
Copy Markdown
Contributor Author

Does the Dockerfile overrides the devcontainer.json? cause it seems like there are different values for the same arguments in those files. For example INSTALL_MAVEN and INSTALL GRADLE have true in devcontainer.json but false in the Dockerfile (it's confusing)

It should override them

@Urook

Urook commented May 18, 2022

Copy link
Copy Markdown
Contributor Author

@EliRookout Should I change it in Dockerfile for clarification's case?

@Urook
Urook requested a review from eli-hatamov-dt May 18, 2022 14:49
@eli-hatamov-dt

Copy link
Copy Markdown

@EliRookout Should I change it in Dockerfile for clarification's case?

I think you should modify the devcontainer.json to have the same values as in the Dockerfile it would be less confusing

@Urook

Urook commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

@EliRookout Done

@Urook
Urook merged commit b3ed56c into master May 24, 2022
@Urook
Urook deleted the add-dev-container branch May 24, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants