Skip to content

ENH: Add Monte Carlo outputs export to CSV/JSON (#242) #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GMinoruy wants to merge 10 commits into
base: develop
Choose a base branch
from
+110 −0
Open

ENH: Add Monte Carlo outputs export to CSV/JSON (#242) #912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e51b221
ENH: trying to add Monte Carlo output to csv and json see issue #242
GMinoruy Dec 4, 2025
fe7c69e
ENH: corrects errors identified during testing
GMinoruy Dec 6, 2025
1c1c77a
ENH: adds example on how to use the export_results function
GMinoruy Dec 6, 2025
ee4bab5
ENH: adds visual feedback when exporting in csv and json
GMinoruy Dec 6, 2025
d0cc223
ENH: adds Docstring to the function
GMinoruy Dec 7, 2025
6503273
ENH: adds unit test of the function export_results
GMinoruy Dec 7, 2025
8eecdc9
Update tests/unit/simulation/test_monte_carlo.py
GMinoruy Apr 21, 2026
a5e77a8
Simplification of f-string usage
GMinoruy Apr 21, 2026
d91ae51
ENH: verifies that files created for tests have proper mock data
GMinoruy Apr 21, 2026
8735ed0
ENH: verifies if the test files actually exists before removing them
GMinoruy Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ENH: adds visual feedback when exporting in csv and json
  • Loading branch information
@GMinoruy @Gui-FernandesBR
GMinoruy authored and Gui-FernandesBR committed Dec 9, 2025
commit ee4bab59c5ed36734d87afa5bf82ba8a18087215
13 changes: 11 additions & 2 deletions docs/notebooks/monte_carlo_analysis/monte_carlo_class_usage.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,9 +811,18 @@
},
{
"cell_type": "code",
"execution_count": 41,
"execution_count": null,
"metadata": {},
"outputs": [],
"outputs": [
{
"name": "stdout",
"output_type": "stream",
"text": [
"Results saved to monte_carlo_analysis_outputs/monte_carlo_csv_output_example as .csv file\n",
"Results saved to monte_carlo_analysis_outputs/monte_carlo_json_output_example as .json file\n"
]
}
],
"source": [
"test_dispersion.export_results(\"monte_carlo_analysis_outputs/monte_carlo_csv_output_example\", \"csv\")\n",
"test_dispersion.export_results(\"monte_carlo_analysis_outputs/monte_carlo_json_output_example\", \"json\")"
Expand Down
2 changes: 2 additions & 0 deletions rocketpy/simulation/monte_carlo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,12 +601,14 @@ def export_results(self, output_filename, output_format):
if output_format == "json":
with open(f"{output_filename}.json", "w", encoding="utf-8") as f:
json.dump(txt_data, f, indent=4)
_SimMonitor.reprint(f"Results saved to {Path(output_filename)} as .json file")
elif output_format == "csv":
output_csv_header = txt_data[0].keys()
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential IndexError if txt_data is empty. If the .outputs.txt file is empty or contains only blank lines, txt_data[0] will raise an IndexError. Add validation to check that txt_data is not empty before attempting to access its first element.

Copilot uses AI. Check for mistakes.
with open(f"{output_filename}.csv", "w", newline= "") as f:
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space before empty string in newline= "" parameter. Should be newline="" (no space before the equals sign) to follow Python style conventions (PEP 8).

Suggested change
with open(f"{output_filename}.csv", "w", newline= "") as f:
with open(f"{output_filename}.csv", "w", newline="") as f:

Copilot uses AI. Check for mistakes.
output_writer = csv.DictWriter(f, fieldnames=output_csv_header)
output_writer.writeheader()
output_writer.writerows(txt_data)
_SimMonitor.reprint(f"Results saved to {Path(output_filename)} as .csv file")
Comment on lines +614 to +625
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation for output_format parameter. The method should validate that output_format is either "csv" or "json" and raise a ValueError with a helpful message if an unsupported format is provided. Currently, if an unsupported format is passed, the method silently does nothing, which could confuse users.

Copilot uses AI. Check for mistakes.

Comment on lines +592 to +626
Copy link
Copy Markdown
Member

@MateusStano MateusStano Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think having this be two different functions export_results_to_csv and export_results_to_json would be cleaner

def __terminate_simulation(self):
"""
Expand Down