Skip to content

BUG: Fix hard-coded radius value for parachute added mass calculation #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 7 commits into from
Mar 14, 2026
Merged

BUG: Fix hard-coded radius value for parachute added mass calculation #889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df536da
Fix hard-coded radius value for parachute added mass calculation
Copilot Nov 28, 2025
6dc2947
Refactor environment method access in controller test for clarity
Gui-FernandesBR Mar 10, 2026
6047147
fix pylint
Gui-FernandesBR Mar 14, 2026
2a7d335
fix comments
Gui-FernandesBR Mar 14, 2026
7bd6b7d
avoid breaking change with drag_coefficient
Gui-FernandesBR Mar 14, 2026
d9bb9e8
reafactors Parachute.__init__ method
Gui-FernandesBR Mar 14, 2026
761f0a4
fix tests
Gui-FernandesBR Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comments
  • Loading branch information
@Gui-FernandesBR
Gui-FernandesBR committed Mar 14, 2026
commit 2a7d33503013c937a40fa0e47ea161c5bbd05a21
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ Attention: The newest changes should be on top -->
- BUG: Fix hard-coded radius value for parachute added mass calculation [#889](https://github.com/RocketPy-Team/RocketPy/pull/889)
- DOC: Fix documentation build [#908](https://github.com/RocketPy-Team/RocketPy/pull/908)
- BUG: energy_data plot not working for 3 dof sims [[#906](https://github.com/RocketPy-Team/RocketPy/issues/906)]
- BUG: Fix parallel Monte Carlo simulation showing incorrect iteration count [#806](https://github.com/RocketPy-Team/RocketPy/pull/806)
- BUG: Fix CSV column header spacing in FlightDataExporter [#864](https://github.com/RocketPy-Team/RocketPy/issues/864)
- BUG: Fix parallel Monte Carlo simulation showing incorrect iteration count [#806](https://github.com/RocketPy-Team/RocketPy/pull/806)
- BUG: Fix missing titles in roll parameter plots for fin sets [#934](https://github.com/RocketPy-Team/RocketPy/pull/934)
Expand Down
2 changes: 1 addition & 1 deletion rocketpy/rocket/rocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,7 +1584,7 @@ def add_parachute(
canopy area), in [0, 1]. Affects only the added-mass scaling
during descent; it does not change `cd_s` (drag). The default
value of 0.0432 yields an `added_mass_coefficient` of
approximately 1.0.
approximately 1.0 ("neutral" added-mass behavior).

Returns
-------
Expand Down
Loading