Skip to content

BUG: fix export ellipses to kml function #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 6 commits into from
Nov 2, 2024
Merged

BUG: fix export ellipses to kml function #712

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5208984
BUG: fix export ellipses to kml function
Gui-FernandesBR Oct 12, 2024
9cde460
BUG: fix export ellipses to kml function
Gui-FernandesBR Oct 12, 2024
05cb03e
Merge branch 'bug/kml-ellipses' of https://github.com/RocketPy-Team/R…
Gui-FernandesBR Nov 1, 2024
dbaba70
MNT: raise error if no apogee or impact data is found for plotting el…
Gui-FernandesBR Nov 1, 2024
ccd0f4e
DEV: Adds #712 to changelog
Gui-FernandesBR Nov 1, 2024
6d7a537
TST: increase monte carlo tests
Gui-FernandesBR Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TST: increase monte carlo tests
  • Loading branch information
@Gui-FernandesBR
Gui-FernandesBR committed Nov 1, 2024
commit 6d7a537c8f739f19e71eef29ddd5243fb9485f64
2 changes: 1 addition & 1 deletion tests/integration/test_monte_carlo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def test_monte_carlo_export_ellipses_to_kml(monte_carlo_calisto_pre_loaded):
filename="monte_carlo_class_example.kml",
origin_lat=32.990254,
origin_lon=-106.974998,
type="impact",
type="all",
)
is None
)
Expand Down
14 changes: 14 additions & 0 deletions tests/unit/test_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
calculate_cubic_hermite_coefficients,
euler313_to_quaternions,
find_roots_cubic_function,
haversine,
)


Expand Down Expand Up @@ -58,3 +59,16 @@ def test_cardanos_root_finding():
assert np.isclose(roots[0].imag, 0)
assert np.isclose(roots[1].imag, 0)
assert np.isclose(roots[2].imag, 0)


@pytest.mark.parametrize(
"lat0, lon0, lat1, lon1, expected_distance",
[
(0, 0, 0, 0, 0),
(45, 45, 45, 45, 0),
(-23.508958, -46.720080, -23.522939, -46.558253, 16591.438),
],
) # These values were calculated with google earth
def test_haversine(lat0, lon0, lat1, lon1, expected_distance):
distance = haversine(lat0, lon0, lat1, lon1)
assert np.isclose(distance, expected_distance, rtol=1e-2)