refactor(ldap-enterprise): LDAP as core-service#40837
Conversation
…it directly
Relocate ILDAPEEService to @rocket.chat/core-services and export an
LDAPEnterprise proxy alongside the other service proxies. All consumers now
import { LDAPEnterprise as LDAPEE } directly from core-services, dropping the
apps/meteor sdk re-export indirection.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #40837 +/- ##
===========================================
- Coverage 70.08% 70.03% -0.05%
===========================================
Files 3337 3337
Lines 123506 123509 +3
Branches 22009 21996 -13
===========================================
- Hits 86557 86499 -58
- Misses 33610 33666 +56
- Partials 3339 3344 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Relocate ILDAPEEService to @rocket.chat/core-services and export an LDAPEnterprise proxy alongside the other service proxies.
All consumers now import { LDAPEnterprise as LDAPEE } directly from core-services, dropping the apps/meteor sdk re-export indirection.