Skip to content

refactor(fuselage-ui-kit): remove unnecessary ReactElement type annotations in components#40809

Draft
tassoevan wants to merge 7 commits into
developfrom
refactor/prepare-types-for-react-19-7
Draft

refactor(fuselage-ui-kit): remove unnecessary ReactElement type annotations in components#40809
tassoevan wants to merge 7 commits into
developfrom
refactor/prepare-types-for-react-19-7

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Jun 4, 2026

⚠️ This is part 7/23 of #40796. PR for refactor/prepare-types-for-react-19-6 must be merged first.

Proposed changes (including videos or screenshots)

As a first step towards upgrading to React 19, it handles types from @types/react looking forward the next major.

Issue(s)

Task: ARCH-2170

Steps to test or reproduce

Further comments

No runtime change is expected from it.

tassoevan added 7 commits June 3, 2026 23:15
@tassoevan
refactor(ui-contexts): update TooltipContext to use ReactNode for pay…
77909cb 
…load type
@tassoevan
refactor(ui-avatar): remove unnecessary ReactElement type annotations…
85d849a 
… from AppAvatar, MessageAvatar, and RoomAvatar components
@tassoevan
refactor(ui-composer): remove unnecessary ReactElement type annotatio…
d816d1e 
…ns across components
@tassoevan
refactor(ui-video-conf): remove unnecessary ReactElement type annotat…
108a417 
…ions across components
@tassoevan
refactor(ui-voip): remove unnecessary ReactElement type annotations a…
68b37d0 
…cross components
@tassoevan
refactor(web-ui-registration): remove unnecessary ReactElement type a…
9a2b41b 
…nnotations across registration components
@tassoevan
refactor(fuselage-ui-kit): remove unnecessary ReactElement type annot…
583408b 
…ations in components

- Updated multiple components to remove explicit return type annotations of ReactElement, allowing TypeScript to infer the return type.
- Adjusted BlockProps to use ReactElement<any> for better type compatibility.
- Cleaned up imports by removing unused ReactElement imports across various files.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 4, 2026

⚠️ No Changeset found

Latest commit: 583408b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c072205-cda6-44df-bb99-7fa555192fb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jun 4, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.51948% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.90%. Comparing base (85fc0dd) to head (583408b).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40809      +/-   ##
===========================================
- Coverage    69.90%   69.90%   -0.01%     
===========================================
  Files         3337     3337              
  Lines       123489   123489              
  Branches     22013    21986      -27     
===========================================
- Hits         86322    86321       -1     
- Misses       33813    33817       +4     
+ Partials      3354     3351       -3
Flag Coverage Δ
unit 70.67% <80.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tassoevan