Added Dividers feature to the mod list#1792
Open
Ketaros wants to merge 10 commits intoRimSort:mainfrom
Open
Conversation
- Disconnect model signals in restore_dividers to prevent duplicate UUID entries in self.uuids from handle_rows_inserted - Add safety guard to skip divider items in error/warning recalculation Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… UI cleanup Co-authored-by: Cursor <cursoragent@cursor.com>
- Split single mod color into independent background color and font color - Add font_color_hex column to aux metadata DB with auto-migration - Add context menu actions: Change background color, Change font color, Reset mod colors - Remove color_background_instead_of_text_toggle setting and checkbox - Fix empty XML description tag causing error log spam - Fix ruff import sorting and add missing DummySettings attributes for tests Co-authored-by: Cursor <cursoragent@cursor.com>
- Add missing type parameters to dict annotations (dict -> dict[str, Any]) - Remove unused type: ignore comment in divider_widget.py - Use separate variable name for divider widget to avoid type narrowing issue Co-authored-by: Cursor <cursoragent@cursor.com>
These auto-generated files should not be part of the PR. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract shared helpers _get_controller_and_session, _get_entry_color_field, _update_single_mod_field, and _update_bulk_mod_field to remove duplicated boilerplate between background color and font color functions. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to insert named, collapsible dividers into the Active mod list, allowing users to visually organize their mods into sections.
Features
New Files
Design Decisions
Dividers use a divider UUID prefix to distinguish them from real mods without changing existing data structures
Dividers are never written to ModsConfig.xml — they are UI-only and stored separately in settings.json
All existing mod iteration loops are guarded with is_divider_uuid() checks to prevent KeyError crashes when accessing internal_local_metadata
Test Plan
[ ] Add a divider via right-click, verify it appears with the entered name
[ ] Rename and delete dividers via right-click context menu
[ ] Collapse/expand a divider by clicking the arrow — mods below should hide/show
[ ] Drag a divider to a new position
[ ] Click Save, restart the app — dividers should be restored at their positions
[ ] Click Sort — mods should sort, dividers should move to the bottom
[ ] Click Clear — dividers should be removed
[ ] Export mod list — verify dividers are not included in ModsConfig.xml
[ ] Search/filter mods — dividers should not interfere with results