Add "Delete" shortcut, mod list download and steam path#1465
Add "Delete" shortcut, mod list download and steam path#1465iMuhammadMustafa wants to merge 3 commits intoRimSort:mainfrom
Conversation
Try searching for "steamcmd_script.txt" and see how it is used in case you have more ideas 
|
| logger.debug("Finished Browser Window initialization") | ||
|
|
||
| def _show_add_mods_by_id_dialog(self): | ||
| from PySide6.QtWidgets import QDialog, QVBoxLayout, QTextEdit, QDialogButtonBox, QLabel |
There was a problem hiding this comment.
Move imports to top of the file to avoid duplicate imports
|
Should be an easy fix based on the error below also read incase https://rimsort.github.io/RimSort/development-guide/contributor-guidelines#misc-coding-style |
| if self.path.startswith("http://") or self.path.startswith("https://"): | ||
| import webbrowser | ||
| try: | ||
| webbrowser.open(self.path) |
There was a problem hiding this comment.
Use platform_specific_open instead of webbrowser.open works with links as well
|
Hi @LionelColaso Thank you so much for reviewing my PR. I moved the PR to draft while I review your comments and resolve it. Thank you |
You should probably create individual pull requests for each feature rather than implementing all at once |
Hello
These are some things that I really needed to exist. I'm not very experienced with python though, so I apologize in advance.
(I needed this because I already had a list from long ago that I wanted to add and sometimes I'm browsing mods from a different laptop and create a list and want to automatically download all of them instead of browsing one by one.)