Skip to content

Add Danish translation#1060

Draft
Limfjorden wants to merge 6 commits intoRimSort:mainfrom
Limfjorden:translation-da
Draft

Add Danish translation#1060
Limfjorden wants to merge 6 commits intoRimSort:mainfrom
Limfjorden:translation-da

Conversation

@Limfjorden
Copy link
Copy Markdown
Contributor

This pull request will add a Danish translation for all strings in RimSort.

@axoroll7
Copy link
Copy Markdown
Contributor

Why the file greenlet.h ?

@Limfjorden
Copy link
Copy Markdown
Contributor Author

I don't know. It was automatically created at some point. If it's not needed I can remove it.

@LionelColaso
Copy link
Copy Markdown
Member

I don't know. It was automatically created at some point. If it's not needed I can remove it.

https://rimsort.github.io/RimSort/development-guide/translation-guidelines

also worth checking
#1052

@oceanfrost
Copy link
Copy Markdown
Collaborator

Some tips:
greenlet.h is not needed.
The current build workflow doesn't include compiling the language files, so you need to upload the .qm files as well.
Add the corresponding mapping in the language controller.

@Limfjorden
Copy link
Copy Markdown
Contributor Author

Why the file greenlet.h ?

Greenlet.h is gone now.

The current build workflow doesn't include compiling the language files, so you need to upload the .qm files as well.

Yeah, I'll do that when I've translated all the strings.

Add the corresponding mapping in the language controller.

Good call, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants