Skip to content

Moving from circleci to gha WRT benchmark flows #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filipecosta90 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Moving from circleci to gha WRT benchmark flows #3209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
067f08a
Moving from circleci to gha WRT benchmark flows
filipecosta90 Oct 11, 2023
2831614
Removed spurious tools related to other performance projects automation
filipecosta90 Oct 11, 2023
15c8bb8
Updated benchmark gha job names
filipecosta90 Oct 11, 2023
3cc29c4
Addressed PR review
filipecosta90 Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Addressed PR review
  • Loading branch information
@filipecosta90
filipecosta90 committed Oct 20, 2023
commit 3cc29c4841deeae7748250ba020f68622627005a
14 changes: 3 additions & 11 deletions .github/workflows/benchmark-flow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This file contains the actual benchmark logic
# that can be triggered from different manners (merges to master, weekly, on PRs)
name: Run a Benchmark Flow

on:
Expand All @@ -9,10 +11,7 @@ on:
module_path:
type: string
default: bin/linux-x64-release/src/redisgraph.so
profile_env:
type: number # for default of 0
cluster_env:
type: string # for default of ""
# specify a test glob pattern to use on the tests directory. by default uses *.yml
benchmark_glob:
Comment thread
filipecosta90 marked this conversation as resolved.
type: string
default: "*.yml"
Expand All @@ -22,8 +21,6 @@ on:
allowed_envs:
type: string
default: "oss-standalone"
allowed_setups:
type: string
benchmark_runner_group_member_id:
type: number
default: 1
Expand Down Expand Up @@ -72,16 +69,12 @@ jobs:
working-directory: tests/benchmarks
continue-on-error: true
env:
# Hard-coded
PERF_CALLGRAPH_MODE: dwarf
MAX_PROFILERS: 1
# Secrets
AWS_ACCESS_KEY_ID: ${{ secrets.PERFORMANCE_EC2_ACCESS_KEY }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.PERFORMANCE_EC2_SECRET_KEY }}
AWS_DEFAULT_REGION: ${{ secrets.PERFORMANCE_EC2_REGION }}
EC2_PRIVATE_PEM: ${{ secrets.PERFORMANCE_EC2_PRIVATE_PEM }}
# Inputs
PROFILE: ${{ inputs.profile_env }}
BENCHMARK_GLOB: ${{ inputs.benchmark_glob }}
BENCHMARK_RUNNER_GROUP_M_ID: ${{ inputs.benchmark_runner_group_member_id }}
BENCHMARK_RUNNER_GROUP_TOTAL: ${{ inputs.benchmark_runner_group_total }}
Expand All @@ -96,7 +89,6 @@ jobs:
--upload_results_s3
--triggering_env ${{ inputs.triggering_env }}
--allowed-envs ${{ inputs.allowed_envs }}
--allowed-setups ${{ inputs.allowed_setups }}
--push_results_redistimeseries
--redistimeseries_host ${{ secrets.PERFORMANCE_RTS_HOST }}
--redistimeseries_port ${{ secrets.PERFORMANCE_RTS_PORT }}
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/benchmark-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ on:

jobs:
benchmark-graph-oss-standalone:
# We split the benchmarks into distinct groups
# and run them concurrently, thus speeding the entire CI feedback cycle.
# Speficially on this job we will split the tests into 6 groups.
# The benchmark flow will then use benchmark_runner_group_member_id to know which
# benchmarks to run for the group it's responsible for.
strategy:
matrix:
member_id: [1, 2, 3, 4, 5, 6]
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/benchmark-trigger.yml → ...b/workflows/benchmark-trigger-from-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
name: Check if needs trigger benchmark
name: Check if needs trigger benchmark as part of PR workflow

on:
pull_request:
types: [opened, labeled, unlabeled, synchronize]

jobs:
# Check if we need to trigger the benchmark as part of PR workflow
# We use the HasLabel action to check if there is a 'run-benchmark' label present.
# If the label is present we trigger the benchmarks.
haslabel:
Comment thread
filipecosta90 marked this conversation as resolved.
name: analyse labels
runs-on: ubuntu-latest
Expand All @@ -19,7 +22,7 @@ jobs:
contains: 'run-benchmark'

perf-ci:
name: Trigger
name: Trigger the benchmark as part of PR workflow
needs: haslabel
if: needs.haslabel.outputs.benchmark
uses: ./.github/workflows/benchmark-runner.yml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/event-push-to-integ.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches:
- master
- 'feature-*'
- '[0-9]+.[0-9]+'

jobs:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/event-weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Weekly Flow

on:
schedule:
# Every Sunday at 00:00
- cron: "0 0 * * 0"
Comment thread
filipecosta90 marked this conversation as resolved.

jobs:
Expand Down