Open
Conversation
This was
linked to
issues
May 11, 2023
Collaborator
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Comparison between master and fix-graphentity-getattributes.Time Period from 30 days ago. (environment used: oss-standalone)
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3080 +/- ##
==========================================
+ Coverage 90.85% 90.93% +0.07%
==========================================
Files 294 294
Lines 30269 30454 +185
==========================================
+ Hits 27502 27694 +192
+ Misses 2767 2760 -7
☔ View full report in Codecov by Sentry. |
swilly22
suggested changes
May 15, 2023
swilly22
suggested changes
May 24, 2023
AviAvni
suggested changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is to solve: #3050, #3054, and #3056.
The function
AttributeSet GraphEntity_GetAttributes(GraphEntity *e)was modified to verify that the pointere->attributes != NULLbefore trying to access its value.