Skip to content

Fix validation in list comprehension and pattern comprehension #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nafraf wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Fix validation in list comprehension and pattern comprehension #2902

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f2d41ed
WIP: FilterTree_Valid() validate predicate
nafraf Feb 18, 2023
a12a73b
WIP: Validate eval nodes containing agg functions
nafraf Feb 19, 2023
9979fc4
WIP: Set error in AR_EXP_ContainsAgg()
nafraf Feb 20, 2023
7a6c8d3
Test list comprehension
nafraf Feb 21, 2023
b0ee948
Merge branch 'RedisGraph:master' into bug#2267
nafraf Feb 21, 2023
8f1f591
Validate list comprehension predicate
nafraf Feb 22, 2023
c902f91
Remove additional space
nafraf Feb 22, 2023
acbb001
Fix buildPatternComprehensionOps to free vars
nafraf Feb 22, 2023
bbb802b
Fix comparison
nafraf Feb 22, 2023
deb113c
Merge branch 'RedisGraph:master' into bug#2267
nafraf Mar 3, 2023
eb8db95
Merge branch 'RedisGraph:master' into bug#2267
nafraf Apr 18, 2023
3b170c7
Merge branch 'master' into bug#2267
nafraf May 4, 2023
a5ebbe9
Merge branch 'RedisGraph:master' into bug#2267
nafraf May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove additional space
  • Loading branch information
@nafraf
nafraf committed Feb 22, 2023
commit c902f91cc5604141d738951a00caad7f228a9338
2 changes: 1 addition & 1 deletion src/arithmetic/arithmetic_expression_construct.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ static AR_ExpNode *_AR_ExpNodeFromComprehensionFunction
if(predicate_node) {
AST_ConvertFilters(&ctx->ft, predicate_node);
// in case of list comprehension, validate that aggregation function is not used in predicate
if( func_name == "LIST_COMPREHENSION" && !FilterTree_Valid(ctx->ft, CYPHER_AST_LIST_COMPREHENSION)) {
if(func_name == "LIST_COMPREHENSION" && !FilterTree_Valid(ctx->ft, CYPHER_AST_LIST_COMPREHENSION)) {
rm_free(ctx);
return AR_EXP_NewConstOperandNode(SI_NullVal());
}
Expand Down