Fix message of unary minus validation

RedisGraph · nafraf · Dec 31, 2022 · Jan 3, 2023 · Jan 3, 2023 · Jan 3, 2023
commit db56e9fb646c9592edfa4b8ddce2db586245dcd1
diff --git a/src/arithmetic/arithmetic_expression_construct.c b/src/arithmetic/arithmetic_expression_construct.c
@@ -246,8 +246,8 @@ static AR_ExpNode *_AR_EXP_FromUnaryOpExpression(const cypher_astnode_t *expr) {
 			op = AR_EXP_NewConstOperandNode(converted);
 			rm_free(minus_str);
 		} else {
-			op = AR_EXP_NewOpNodeFromAST(OP_MULT, 2);
-			op->op.children[0] = AR_EXP_NewConstOperandNode(SI_LongVal(-1));
+			op = AR_EXP_NewOpNodeFromAST(OP_MINUS, 2);
+			op->op.children[0] = AR_EXP_NewConstOperandNode(SI_LongVal(0));
 			op->op.children[1] = _AR_EXP_FromASTNode(arg);
 		}
 	} else if(operator == CYPHER_OP_UNARY_PLUS) {

diff --git a/tests/flow/test_function_calls.py b/tests/flow/test_function_calls.py
@@ -2231,6 +2231,7 @@ def test86_type_mismatch_message(self):
             "RETURN isEmpty(1)" : "Type mismatch on function 'isEmpty' argument 1: expected Map, List, String, or Null but was Integer",
             "CREATE ()-[r:R]->() RETURN toString(r)" : "Type mismatch on function 'tostring' argument 1: expected Datetime, Duration, String, Boolean, Integer, Float, Point, or Null but was Edge",
             "MERGE p=() RETURN p.name" : "Type mismatch on operator '.' left argument: expected Map, Node, Edge, Point, or Null but was Path",
+            "RETURN -'a'" : "Type mismatch on operator '-' right argument: expected Integer, Float, or Null but was String",
             "RETURN 'a'-2" : "Type mismatch on operator '-' left argument: expected Integer, Float, or Null but was String",
             "RETURN 1*'a'" : "Type mismatch on operator '*' right argument: expected Integer, Float, or Null but was String",
             "RETURN 2^'a'" : "Type mismatch on operator '^' right argument: expected Integer, Float, or Null but was String",