3.x: Fix source locator code to support GitHub Actions folder layout#7113
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #7113 +/- ##
============================================
- Coverage 99.54% 99.51% -0.03%
- Complexity 6670 6671 +1
============================================
Files 742 742
Lines 47275 47275
Branches 6374 6374
============================================
- Hits 47062 47048 -14
- Misses 97 108 +11
- Partials 116 119 +3 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Action
actions/checkout@v2downloads the files to a directory that doesn't appear to include therxjavaname anymore and makes the source code tests unable to read the files.This changes the locator to try for
src/main/javain each parent directory relative to where the class files are located viagetResource.This is a preparation in case we have to bail from Travis CI. They now have a pricing model that in theory would be free for open source projects still but who knows in practice as there are hops apparently to get projects recognized as such.