2.x: Factor out typical TestObserver/TestSubscriber methods#4609
Merged
Conversation
JakeWharton
approved these changes
Sep 26, 2016
Member
Author
|
The drawback is that the generated javadoc doesn't have the method documentation and doesn't reference
|
Current coverage is 78.12% (diff: 99.02%)@@ 2.x #4609 diff @@
==========================================
Files 552 553 +1
Lines 36327 36128 -199
Methods 0 0
Messages 0 0
Branches 5611 5559 -52
==========================================
- Hits 28405 28225 -180
+ Misses 5908 5890 -18
+ Partials 2014 2013 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new abstract internal class
BaseTestConsumerwhich now hosts theassertXmethods ofTestSubscriberandTestObserverwhich were duplicates before.