Skip to content

2.x: Publish code coverage results to codecov.io#4048

Merged
zsxwing merged 1 commit into
ReactiveX:2.xfrom
zsxwing:code-coverage-2.x
Jun 20, 2016
Merged

2.x: Publish code coverage results to codecov.io#4048
zsxwing merged 1 commit into
ReactiveX:2.xfrom
zsxwing:code-coverage-2.x

Conversation

@zsxwing
Copy link
Copy Markdown
Member

@zsxwing zsxwing commented Jun 20, 2016

Same as #4046 except the badge link.

@zsxwing zsxwing added the Build label Jun 20, 2016
@zsxwing zsxwing self-assigned this Jun 20, 2016
@codecov-io
Copy link
Copy Markdown

Current coverage is 69.61%

No coverage report found for 2.x at 95febf4.

Powered by Codecov. Last updated by 95febf4...94274ba

@akarnokd
Copy link
Copy Markdown
Member

👍

@zsxwing zsxwing merged commit c566054 into ReactiveX:2.x Jun 20, 2016
@zsxwing zsxwing deleted the code-coverage-2.x branch June 20, 2016 22:03
@artem-zinnatullin
Copy link
Copy Markdown
Contributor

👍 @zsxwing can you also enable commits status check in codecov settings?

@zsxwing
Copy link
Copy Markdown
Member Author

zsxwing commented Jun 20, 2016

@artem-zinnatullin which button is for commits status check?

@artem-zinnatullin
Copy link
Copy Markdown
Contributor

@zsxwing they've recently made major update and moved most of the settings to codecov.yml, looks like commit status check is now also lives there: https://codecov.io/docs#yaml_default_commit_status

@akarnokd akarnokd added this to the 2.0 RC 1 milestone Jun 21, 2016
@zsxwing
Copy link
Copy Markdown
Member Author

zsxwing commented Jun 21, 2016

Codecov will enable three unique commit statuses by default

@artem-zinnatullin I think it's enabled already.

@artem-zinnatullin
Copy link
Copy Markdown
Contributor

@zsxwing hm, but I don't see status checks from Codecov on GitHub, only report from Travis. Did you give required permissions to Codecov on GitHub? Probably configuration of ReactiveX organization does not allow transparent access to repos for apps authorized by its members.

@zsxwing
Copy link
Copy Markdown
Member Author

zsxwing commented Jun 22, 2016

@artem-zinnatullin Figured it out. Need some admin to click the Create New Webhook button in this page: https://codecov.io/gh/ReactiveX/RxJava/settings. @benjchristensen or @abersnaze can do it.

@artem-zinnatullin
Copy link
Copy Markdown
Contributor

Yeah, thanks @zsxwing.

@abersnaze can you please allow Codecov to post commit statuses to the project like Travis is doing now? https://codecov.io/gh/ReactiveX/RxJava/settings

This will ensure that coverage fail (significant decrease/etc) is visible on the Pull Requests list page and will block/mark_as_yellow the merge button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants