Skip to content

Fix ListOf inheritance and compatibility of NamesProxy #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddelbuettel merged 5 commits into from
Apr 9, 2026
+29 −26
Merged

Fix ListOf inheritance and compatibility of NamesProxy #1464

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53bcd5c
fix ListOf inheritance
Enchufa2 Mar 27, 2026
05f4b03
update ChangeLog
Enchufa2 Mar 27, 2026
56c51f1
Refine NamesProxy setter to set only non-NULL values
eddelbuettel Apr 3, 2026
6b25d59
allow name removal
Enchufa2 Apr 6, 2026
0c95245
complete test cases for setting NamesProxy
Enchufa2 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allow name removal
  • Loading branch information
@Enchufa2 @eddelbuettel
Enchufa2 authored and eddelbuettel committed Apr 7, 2026
commit 6b25d596717904b2809fc066d1c93606d25c6be5
3 changes: 2 additions & 1 deletion inst/include/Rcpp/proxy/NamesProxy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ class NamesProxyPolicy{

void set(SEXP x) {
if (!Rf_isNull(x))
Rf_namesgets(parent, Shield<SEXP>(x));
Rf_namesgets(parent, x);
else Rf_setAttrib(parent, R_NamesSymbol, x);
Copy link
Copy Markdown
Member

@eddelbuettel eddelbuettel Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for catching that.

}

} ;
Expand Down