Skip to content

add template specializations to avoid DATAPTR use #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddelbuettel merged 15 commits into from
Jun 22, 2024
Merged

add template specializations to avoid DATAPTR use #1310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
936c19b
add template specializations to avoid DATAPTR use
kevinushey Jun 11, 2024
d48a6ed
also implement bounds checking in vector access
kevinushey Jun 11, 2024
84c885a
tweak error message
kevinushey Jun 11, 2024
3addbc9
add tests; implement bounds check for proxy
kevinushey Jun 11, 2024
394e220
finish NEWS
kevinushey Jun 11, 2024
c8c3a5c
don't check index when constructing iterators
kevinushey Jun 11, 2024
1d7ce1b
avoid invoking wrong 'get'
kevinushey Jun 11, 2024
4c8df0c
don't pass 'ncpus'
kevinushey Jun 11, 2024
2520e51
finish NEWS
kevinushey Jun 11, 2024
528f453
test tweaks
kevinushey Jun 11, 2024
69cb4dd
Small robustification for package version check during dev cycle
eddelbuettel Jun 12, 2024
bc529e0
use warning instead of stop
kevinushey Jun 18, 2024
d412e22
update NEWS
kevinushey Jun 18, 2024
3f4d5df
NEWS once more
kevinushey Jun 18, 2024
c1ca0bb
fixup for check_indices in subsetter
kevinushey Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test tweaks
  • Loading branch information
@kevinushey
kevinushey committed Jun 11, 2024
commit 528f453910da900d9a9c37a2b5cb41b0d405cd13
10 changes: 4 additions & 6 deletions inst/tinytest/cpp/Vector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,13 +888,11 @@ bool CharacterVector_test_equality_crosspolicy(CharacterVector x, Vector<STRSXP,
}

// [[Rcpp::export]]
double NumericVector_test_out_of_bounds_read() {
NumericVector v(3);
return v[5];
double NumericVector_test_out_of_bounds_read(NumericVector v, R_xlen_t i) {
return v[i];
}

// [[Rcpp::export]]
SEXP CharacterVector_test_out_of_bounds_read() {
CharacterVector v(3);
return v[5];
SEXP CharacterVector_test_out_of_bounds_read(CharacterVector v, R_xlen_t i) {
return v[i];
}
7 changes: 5 additions & 2 deletions inst/tinytest/test_vector.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,9 @@ expect_equal(data, data2)
expect_true( !CharacterVector_test_equality("foo", "bar") )
expect_true( !CharacterVector_test_equality_crosspolicy("foo", "bar") )

# https://github.com/RcppCore/Rcpp/issues/1308
expect_error(NumericVector_test_out_of_bounds_read(numeric(0), 0))
expect_error(NumericVector_test_out_of_bounds_read(numeric(1), 1))
expect_error(CharacterVector_test_out_of_bounds_read(character(0), 0))
expect_error(CharacterVector_test_out_of_bounds_read(character(1), 1))

expect_error(NumericVector_test_out_of_bounds_read())
expect_error(CharacterVector_test_out_of_bounds_read())