Skip to content

fix(core): fix memory leak on application reference destroy - #1

Merged
RatkoR merged 1 commit into
RatkoR:masterfrom
tmair:fix-application-destroy-memory-leak
Apr 4, 2018
Merged

RatkoR merged 1 commit into
RatkoR:masterfrom
tmair:fix-application-destroy-memory-leak

Conversation

@RatkoR

@RatkoR RatkoR commented Apr 4, 2018

Copy link
Copy Markdown
Owner

When an application reference is destroyed it stays in memory because it is still registered in the testability registry.

Closes angular#22106, angular#13725

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

When an application reference is destroyed it stays in memory because it is still registered in the testability registry.

Closes angular#22106, angular#13725
@RatkoR
RatkoR merged commit 3c46dc7 into RatkoR:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application stays in memory even after being destroyed

2 participants