Skip to content

S260106 : Upgrade toolkit to work with Jetty12 #39

Merged
kworam-rally merged 6 commits into
masterfrom
upgrade_http_client
Feb 22, 2024
Merged

S260106 : Upgrade toolkit to work with Jetty12 #39
kworam-rally merged 6 commits into
masterfrom
upgrade_http_client

Conversation

@kworam-rally

@kworam-rally kworam-rally commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

upgrade to work correctly with Jetty12

S260106: Upgrade RallyRestToolkitForJava to support Jetty12

Comment thread pom.xml Outdated
@@ -28,6 +32,10 @@
<id>krmorse</id>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this whole developers section... I don't think we want people to think we actually actively develop this anymore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kworam-rally kworam-rally changed the title Upgrade http client Upgrade toolkit to work with Jetty12 Jan 23, 2024

@klehman-rally klehman-rally left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that the language level changed from JDK_1_5 to JDK_1_8.
What effect would there be to changing the language level to a version that is more current? Would there be any benefit to that?

@kworam-rally

Copy link
Copy Markdown
Contributor Author

I note that the language level changed from JDK_1_5 to JDK_1_8. What effect would there be to changing the language level to a version that is more current? Would there be any benefit to that?

I wanted to make the minimal change to get the toolkit fixed. It seems to me there won't be much benefit to upgrading to a more recent JDK and it might break some other code somewhere in the toolkit

@kworam-rally kworam-rally merged commit 83d8c1e into master Feb 22, 2024
@kworam-rally kworam-rally changed the title Upgrade toolkit to work with Jetty12 S260106 : Upgrade toolkit to work with Jetty12 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants