Week3#3
Merged
Merged
Conversation
Week1-Assignment Merging after fixing review comments
Week2 - Merging after incorporating the review comments.
grod220
approved these changes
Aug 29, 2019
grod220
left a comment
There was a problem hiding this comment.
Wow! 🎆
This assignment was definitely a toughie. Well done ✅
| const root = document.getElementById('root'); | ||
|
|
||
| Util.createAndAppend('h1', root, { text: 'It works!' }); // TODO: replace with your own code | ||
| // Create div element 'select' in document body to hold the label element and list box. |
| }); | ||
|
|
||
| let keyIndex; | ||
| console.log(selectBox.value); |
There was a problem hiding this comment.
In general, best to remove console.logs before merging. So your other colleagues don't get annoyed with your logs when they work in different parts of the app ;)
Owner
Author
There was a problem hiding this comment.
I have remove the console.log statement.
Owner
Author
There was a problem hiding this comment.
Shall i merge the Week3 branch with master?
| }); | ||
| this.fetchContributorsAndRender(keyIndex); | ||
| }); | ||
| } catch (error) { |
There was a problem hiding this comment.
This catch could probably just wrap the const repos = await Util.fetchJSON(url); line. Being picky though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week3 Changes