Skip to content

Properly update Renderer.can_render #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VirxEC merged 3 commits into from
Jan 3, 2026
Merged

Properly update Renderer.can_render #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10fa440
Properly update `Renderer.can_render`
VirxEC Jan 3, 2026
2198395
Add new maps
VirxEC Jan 3, 2026
f1e420a
Handle `flat.RenderingStatus` entirely within `SocketRelay`
VirxEC Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Handle flat.RenderingStatus entirely within SocketRelay
  • Loading branch information
@VirxEC
VirxEC committed Jan 3, 2026
commit f1e420a03e60df912b57d277f6f9176efa3a8569
4 changes: 1 addition & 3 deletions rlbot/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class SocketRelay:
controllable_team_info_handlers: list[
Callable[[flat.ControllableTeamInfo], None]
] = []
rendering_status_handlers: list[Callable[[flat.RenderingStatus], None]] = []
raw_handlers: list[Callable[[flat.CorePacket], None]] = []

socket: sock | None = None
Expand Down Expand Up @@ -314,8 +313,7 @@ def handle_incoming_message(self, incoming_message: bytes) -> MsgHandlingResult:
for handler in self.controllable_team_info_handlers:
handler(controllable_team_info)
case flat.RenderingStatus() as rendering_status:
for handler in self.rendering_status_handlers:
handler(rendering_status)
self.can_render = rendering_status.status
case _:
self.logger.warning(
"Received unknown message type: %s",
Expand Down
12 changes: 0 additions & 12 deletions rlbot/managers/bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ def __init__(self, default_agent_id: str | None = None):
self._handle_controllable_team_info
)
self._game_interface.packet_handlers.append(self._handle_packet)
self._game_interface.rendering_status_handlers.append(
self.rendering_status_update
)

self.renderer = Renderer(self._game_interface)

Expand Down Expand Up @@ -224,15 +221,6 @@ def _handle_match_communication(self, match_comm: flat.MatchComm):
match_comm.team_only,
)

def rendering_status_update(self, update: flat.RenderingStatus):
"""
Called when the server sends a rendering status update for ANY bot or script.

By default, this will update `self.renderer.can_render` if appropriate.
"""
if update.is_bot and update.index == self.index:
self._game_interface.can_render = update.status

def update_rendering_status(
self,
status: bool,
Expand Down
12 changes: 0 additions & 12 deletions rlbot/managers/hivemind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ def __init__(self, default_agent_id: str | None = None):
self._handle_controllable_team_info
)
self._game_interface.packet_handlers.append(self._handle_packet)
self._game_interface.rendering_status_handlers.append(
self.rendering_status_update
)

self.renderer = Renderer(self._game_interface)

Expand Down Expand Up @@ -225,15 +222,6 @@ def run(
self.retire()
del self._game_interface

def rendering_status_update(self, update: flat.RenderingStatus):
"""
Called when the server sends a rendering status update for ANY bot or script.

By default, this will update `self.renderer.can_render` if appropriate.
"""
if update.is_bot and update.index in self.indices:
self._game_interface.can_render = update.status

def update_rendering_status(
self,
status: bool,
Expand Down
12 changes: 0 additions & 12 deletions rlbot/managers/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ def __init__(self, default_agent_id: str | None = None):
self._handle_ball_prediction
)
self._game_interface.packet_handlers.append(self._handle_packet)
self._game_interface.rendering_status_handlers.append(
self.rendering_status_update
)

self.renderer = Renderer(self._game_interface)

Expand Down Expand Up @@ -184,15 +181,6 @@ def _handle_match_communication(self, match_comm: flat.MatchComm):
match_comm.team_only,
)

def rendering_status_update(self, update: flat.RenderingStatus):
"""
Called when the server sends a rendering status update for ANY bot or script.

By default, this will update `self.renderer.can_render` if appropriate.
"""
if not update.is_bot and update.index == self.index:
self._game_interface.can_render = update.status

def update_rendering_status(
self,
status: bool,
Expand Down