Fix breaking QuickSpec usage when building under Strict Concurrency#1299
Open
younata wants to merge 2 commits into
Open
Fix breaking QuickSpec usage when building under Strict Concurrency#1299younata wants to merge 2 commits into
younata wants to merge 2 commits into
Conversation
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1298
#1289, which seemed like good idea at the time, ended up breaking standard specs when building under strict concurrency.
This will reintroduce build errors of type "Main actor-isolated property 'stateSubject' can not be referenced from a non-isolated context" and "Call to main actor-isolated initializer 'init()' in a synchronous nonisolated context" when calling main actor-actor isolated code from a QuickSpec. The workaround for these errors is to wrap the code in
MainActor.assumeIsolated.Admin note: Before I release the next version of Quick with this change, I'm going to look at other ways to mitigate the "Main actor-isolated ..." errors.