Skip to content

Refactor tests to remove the embedded git #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 12 commits into from
Aug 7, 2025
Merged

Refactor tests to remove the embedded git #32

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7c1cfab
refactor tests to remove the embedded git
SandrineP Aug 1, 2025
0d8a860
add a blank file to commit the data folder
SandrineP Aug 1, 2025
9951eba
remove reset from commit test
SandrineP Aug 1, 2025
0a1396f
test with .gitconfig
SandrineP Aug 1, 2025
242866e
edit conftest
SandrineP Aug 1, 2025
b018325
use monkeypatch in conftest
SandrineP Aug 4, 2025
fb81746
small fix
SandrineP Aug 4, 2025
89162b5
try with os
SandrineP Aug 4, 2025
f03ec24
new try with os
SandrineP Aug 7, 2025
d2fd475
try with monkeypatch and committer
SandrineP Aug 7, 2025
cccdc4c
try with monkeypatch with author and committer
SandrineP Aug 7, 2025
3248cd6
address review comments
SandrineP Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use monkeypatch in conftest
  • Loading branch information
@SandrineP
SandrineP committed Aug 4, 2025
commit b0183250e9978d15b5bdd803e024cf0f2fa899de
12 changes: 3 additions & 9 deletions test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ def xtl_clone(git2cpp_path):
subprocess.run(cleanup_cmd, capture_output=True, cwd = clone_working_dir, text=True)

@pytest.fixture
def git_config(git2cpp_path):
gitconfig_path = "~/.gitconfig"
if not(os.path.isfile(gitconfig_path)):
with open("~/.gitconfig", "a") as f:
f.write("[user]\n name = Jane Doe\n email = jane.doe@blabla.com")

yield

os.remove("test/data/.gitconfig")
def git_config(git2cpp_path, monkeypatch):
Comment thread
ianthomas23 marked this conversation as resolved.
Outdated
monkeypatch.setenv("GIT_AUTHOR_NAME", "Jane Doe")
monkeypatch.setenv("GIT_AUTHOR_EMAIL", "jane.doe@blabla.com")
Loading