Skip to content

feat: add add subcommand #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 10 commits into from
Jul 17, 2025
Merged

feat: add add subcommand #16

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
26a846b
add add subcommand
SandrineP Jul 9, 2025
39dc847
fix cmake
SandrineP Jul 9, 2025
65485be
edit add subcommand
SandrineP Jul 11, 2025
7e5ea3a
fix 'add --all'
SandrineP Jul 15, 2025
ed4fe0e
fix add_entries
SandrineP Jul 15, 2025
ccb3077
update test
SandrineP Jul 15, 2025
75f8c47
fix typo
SandrineP Jul 16, 2025
d232da9
integrate git_strarray wrapper
SandrineP Jul 17, 2025
893eec9
address review comments
SandrineP Jul 17, 2025
3e8c3d0
address review comments
SandrineP Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address review comments
  • Loading branch information
@SandrineP
SandrineP committed Jul 17, 2025
commit 3e8c3d086008a44e13fe3d6091f6f9726055a107
4 changes: 2 additions & 2 deletions test/test_add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@
def test_add(git2cpp_path, all_flag):
with open("./test/mook_file.txt", "x") as f:
pass
f.close()

with open("./test/mook_file_2.txt", "x") as f:
pass
f.close()

cmd_add = [git2cpp_path, 'add']
if all_flag != "":
Expand All @@ -33,4 +31,6 @@ def test_add(git2cpp_path, all_flag):

os.remove("./test/mook_file.txt")
os.remove("./test/mook_file_2.txt")

# undo the add, to leave the test directory at the end the same as it was at the start
subprocess.run(cmd_add, capture_output=True, text=True)
Copy link
Copy Markdown
Member

@ianthomas23 ianthomas23 Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line just to undo the add, to leave the test directory at the end the same as it was at the start? If so can you add a comment saying this, otherwise it will look suspicious in future to have this line without any following assert.

Copy link
Copy Markdown
Collaborator Author

@SandrineP SandrineP Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the reason why ! I'll write a comment.