Skip to content

Add branches to push subcommand#126

Merged
JohanMabille merged 4 commits intoQuantStack:mainfrom
SandrineP:push_branch
Apr 17, 2026
Merged

Add branches to push subcommand#126
JohanMabille merged 4 commits intoQuantStack:mainfrom
SandrineP:push_branch

Conversation

@SandrineP
Copy link
Copy Markdown
Collaborator

@SandrineP SandrineP commented Mar 24, 2026

Fix #98
Add <branch> and --branches flag to push subcommand.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 68.33333% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.52%. Comparing base (f2e1dfb) to head (0e91868).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/subcommand/push_subcommand.cpp 64.83% 32 Missing ⚠️
src/utils/progress.cpp 25.00% 3 Missing ⚠️
src/wrapper/repository_wrapper.cpp 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   88.27%   86.52%   -1.76%     
==========================================
  Files          61       61              
  Lines        2627     2730     +103     
  Branches      309      329      +20     
==========================================
+ Hits         2319     2362      +43     
- Misses        308      368      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SandrineP SandrineP force-pushed the push_branch branch 2 times, most recently from c20f637 to 07a6ea8 Compare April 7, 2026 14:16
@SandrineP SandrineP marked this pull request as ready for review April 7, 2026 15:25
@SandrineP SandrineP marked this pull request as draft April 13, 2026 13:08
@SandrineP SandrineP marked this pull request as ready for review April 17, 2026 11:25
Comment thread src/subcommand/push_subcommand.cpp Outdated
{
const std::string name = br.first;
const git_oid& oid = br.second;
if (remotes_before_push.find(name) == remotes_before_push.end())
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (remotes_before_push.find(name) == remotes_before_push.end())
if (!remotes_before_push.contains(name))

Comment thread src/subcommand/push_subcommand.cpp Outdated

for (const auto refspec : refspecs)
{
if (new_branches.find(refspec) == new_branches.end())
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (new_branches.find(refspec) == new_branches.end())
if (!new_branches.contains(refspec))

@JohanMabille JohanMabille merged commit 22db9ed into QuantStack:main Apr 17, 2026
4 of 7 checks passed
@SandrineP SandrineP deleted the push_branch branch April 17, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for git push <remote name> <branch name>

2 participants