Skip to content

Add --abbrev-commit, --format=oneline and --oneline to the log subcommand #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 3 commits into from
Mar 11, 2026
Merged

Add --abbrev-commit, --format=oneline and --oneline to the log subcommand #118

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87be596
Add --abbrev-commit, --pretty and --oneline to the log subcommand
SandrineP Mar 9, 2026
3aa613e
address review cooment
SandrineP Mar 11, 2026
b66f83d
Address review comment
SandrineP Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review comment
  • Loading branch information
@SandrineP
SandrineP committed Mar 11, 2026
commit b66f83d11368f5f011396fd1895459461f98d123
40 changes: 18 additions & 22 deletions src/subcommand/revparse_subcommand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,33 +37,29 @@ void revparse_subcommand::run()
auto repo = repository_wrapper::open(directory);

size_t i = 0;
if (!m_queries_in_order.empty())
for (const auto& q : m_queries_in_order)
{
for (const auto& q : m_queries_in_order)
if (q == "is_bare")
{
if (q == "is_bare")
{
std::cout << std::boolalpha << repo.is_bare() << std::endl;
}
else if (q == "is_shallow")
std::cout << std::boolalpha << repo.is_bare() << std::endl;
}
else if (q == "is_shallow")
{
std::cout << std::boolalpha << repo.is_shallow() << std::endl;
}
else if (q == "is_rev")
{
const auto& rev = m_revisions[i];
auto obj = repo.revparse_single(rev.c_str());

if (!obj.has_value())
{
std::cout << std::boolalpha << repo.is_shallow() << std::endl;
throw git_exception("bad revision '" + rev + "'", git2cpp_error_code::BAD_ARGUMENT);
}
else if (q == "is_rev")
{
const auto& rev = m_revisions[i];
auto obj = repo.revparse_single(rev.c_str());

if (!obj.has_value())
{
throw git_exception("bad revision '" + rev + "'", git2cpp_error_code::BAD_ARGUMENT);
}

auto oid = obj.value().oid();
std::cout << git_oid_tostr_s(&oid) << std::endl;
i += 1;
}
auto oid = obj.value().oid();
std::cout << git_oid_tostr_s(&oid) << std::endl;
i += 1;
}
}
Copy link
Copy Markdown
Member

@JohanMabille JohanMabille Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using else here would avoid the need for the previous return statement

return;
}
Loading