Skip to content

Add tracking info for log subcommand #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 3 commits into from
Feb 27, 2026
Merged

Add tracking info for log subcommand #106

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81992bd
Add tracking info
SandrineP Feb 24, 2026
807cb09
address review comments
SandrineP Feb 27, 2026
8e58bbc
address review comments
SandrineP Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address review comments
  • Loading branch information
@SandrineP
SandrineP committed Feb 27, 2026
commit 8e58bbc38eb8ffad926bb1366facc3baaadd052c
9 changes: 4 additions & 5 deletions src/subcommand/log_subcommand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void print_time(git_time intime, std::string prefix)
std::cout << prefix << out << " " << sign << std::format("{:02d}", hours) << std::format("{:02d}", minutes) <<std::endl;
}

std::vector<std::string> get_tags_for_commit(repository_wrapper& repo, const git_oid* commit_oid)
std::vector<std::string> get_tags_for_commit(repository_wrapper& repo, const git_oid& commit_oid)
{
std::vector<std::string> tags;
git_strarray tag_names = {0};
Expand All @@ -71,7 +71,7 @@ std::vector<std::string> get_tags_for_commit(repository_wrapper& repo, const git
reference_wrapper tag_ref = repo.find_reference(ref_name);
object_wrapper peeled = tag_ref.peel<object_wrapper>();

if (git_oid_equal(&peeled.oid(), commit_oid))
if (git_oid_equal(&peeled.oid(), &commit_oid))
{
tags.push_back(std::string(tag_name));
}
Expand Down Expand Up @@ -107,8 +107,7 @@ std::vector<std::string> get_branches_for_commit(repository_wrapper& repo, git_b

if (branch_target && git_oid_equal(branch_target, &commit_oid))
{
std::string branch_name;
branch_name = branch->name();
std::string branch_name(branch->name());
if (type == GIT_BRANCH_LOCAL)
{
if (branch_name != exclude_branch)
Expand Down Expand Up @@ -153,7 +152,7 @@ commit_refs get_refs_for_commit(repository_wrapper& repo, const git_oid& commit_
}
}

refs.tags = get_tags_for_commit(repo, &commit_oid);
refs.tags = get_tags_for_commit(repo, commit_oid);
refs.local_branches = get_branches_for_commit(repo, GIT_BRANCH_LOCAL, commit_oid, refs.head_branch);
refs.remote_branches = get_branches_for_commit(repo, GIT_BRANCH_REMOTE, commit_oid, "");

Expand Down