Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Terminal Based Hangman Game#253

Merged
AdityaJ7 merged 4 commits into
Python-World:masterfrom
neohboonyee99:terminal_based_hangman_game
Sep 24, 2020
Merged

Terminal Based Hangman Game#253
AdityaJ7 merged 4 commits into
Python-World:masterfrom
neohboonyee99:terminal_based_hangman_game

Conversation

@neohboonyee99
Copy link
Copy Markdown

@neohboonyee99 neohboonyee99 commented Sep 23, 2020 •
edited by AdityaJ7
Loading

#Description

Contains hangman.py and words.py
The terminal based hangman game is complete and can be run in terminal.

Fixes #177

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@neohboonyee99 neohboonyee99 changed the title -Finished creating a terminal based hangman game Terminal Based Hangman Game #5 Sep 23, 2020
@neohboonyee99 neohboonyee99 changed the title Terminal Based Hangman Game #5 Terminal Based Hangman Game Sep 23, 2020
AdityaJ7
AdityaJ7 suggested changes Sep 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@AdityaJ7 AdityaJ7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @neohboonyee99 it would be better if you store the list of words in a .JSON file.

@neohboonyee99
Copy link
Copy Markdown
Author

neohboonyee99 commented Sep 23, 2020

@AdityaJ7 ok I will change it

@boonyee99
-Changed to list of word in json format
4cc178c 
-Changed the way to get the word from json in hangman.py
chavarera
chavarera suggested changes Sep 23, 2020
View reviewed changes
Comment thread projects/Terminal_Based_Hangman_Game/hangman.py Outdated
Comment thread projects/Terminal_Based_Hangman_Game/hangman.py Outdated
boonyee99 and others added 2 commits September 24, 2020 17:09
@AdityaJ7 AdityaJ7 self-requested a review September 24, 2020 13:37
AdityaJ7
AdityaJ7 approved these changes Sep 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!!!

@AdityaJ7 AdityaJ7 merged commit 983f9c5 into Python-World:master Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chavarera chavarera chavarera requested changes

@AdityaJ7 AdityaJ7 AdityaJ7 approved these changes

@tusharnankani tusharnankani tusharnankani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a terminal-based Hangman Game

5 participants

@neohboonyee99 @chavarera @AdityaJ7 @tusharnankani @boonyee99