refactor package info to setup.cfg, run pyupgrade#34
Merged
digitalresistor merged 2 commits intomasterfrom May 16, 2022
Merged
Conversation
digitalresistor
requested changes
May 16, 2022
Member
digitalresistor
left a comment
There was a problem hiding this comment.
Just some things I saw, unless you want to address them elsewhere?
|
|
||
| class InterpolateWrapper(object): | ||
| class InterpolateWrapper: | ||
| # Python >= 3.2 |
Member
There was a problem hiding this comment.
Is there a Python less than 3 branch here somewhere?
I'm on mobile!
Member
Author
There was a problem hiding this comment.
thanks, removed that code
| @@ -102,7 +102,7 @@ def before_get(self, parser, section, option, value, defaults): | |||
| except Exception: | |||
Member
There was a problem hiding this comment.
This seems like a really yucky way to reraise with a changed exception message.
Member
Author
There was a problem hiding this comment.
yeah, not going to try to clean it up right now though :-)
| version = 2.1.1 | ||
| author = Ian Bicking | ||
| author_email = pylons-discuss@googlegroups.com | ||
| maintainer = Chris Dent |
Member
There was a problem hiding this comment.
This should probably be changed?
Member
Author
There was a problem hiding this comment.
Dunno, would have to find out if chris is around - going to leave it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.