Replace toml with tomli#829
Merged
ericwb merged 3 commits intoPyCQA:mainfrom Mar 25, 2022
mkniewallner:replace-toml-with-tomli
Merged
Replace toml with tomli#829ericwb merged 3 commits intoPyCQA:mainfrom mkniewallner:replace-toml-with-tomli
toml with tomli#829ericwb merged 3 commits intoPyCQA:mainfrom
mkniewallner:replace-toml-with-tomli
Conversation
Contributor
Author
|
As python/cpython#31498 has been merged, I also added d40fed8 to only require Note that |
ericwb
reviewed
Mar 25, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #828
Replace
tomlwithtomlifor parsing bandit options defined inpyproject.toml.The reason for requiring at least
1.1.0is because support for text files has been deprecated in 1.2.0 then removed in 2.0.0, and support for binary files has only been added in 1.1.0, so this ensures that users have1.1.0+, to reliably be able to read binary files.As
tomlionly reads binary files, it is required to open the file usingrbflags, which also impacts the format passed tosafe_loadfor YAML files, butPyYAMLaccepts both binary and text files, so this still works as expected, though this may slow down a bit parsing time.