Working version#1
Merged
Merged
Conversation
ikovalyov
reviewed
Jan 20, 2017
| } | ||
|
|
||
|
|
||
| $roles = $this->entityManager->getRepository(Role::class)->findAll(); |
ikovalyov
reviewed
Jan 20, 2017
|
|
||
| 'options' => [ | ||
| 'label' => 'Role', | ||
| 'value_options' => $rolesselector, |
ikovalyov
reviewed
Jan 20, 2017
| 'name' => 'password', | ||
| 'required' => true, | ||
| 'filters' => [ | ||
| ['name' => 'StringTrim'], |
Author
There was a problem hiding this comment.
No, it seems that You have been mistaken by old filters and new filters location
ikovalyov
reviewed
Jan 20, 2017
|
|
||
| // Get role object based on role Id from form | ||
| /** @var Role $role */ | ||
| $role = $this->entityManager->find(Role::class, ['roleId' => $data['role']]); |
There was a problem hiding this comment.
can't you just pass role id here? I guess doctrine is smart enough.
ikovalyov
reviewed
Jan 20, 2017
| /** @var Role $role */ | ||
| $role = $this->entityManager->find(Role::class, ['roleId' => $data['role']]); | ||
| // Set role to user | ||
| $user->addRole($role); |
There was a problem hiding this comment.
Also don't forget to remove previous role
ikovalyov
reviewed
Jan 20, 2017
| /** @var Role $role */ | ||
| $role = $this->entityManager->find(Role::class, ['roleId' => 2]); | ||
| // Set role to user | ||
| $user->addRole($role); |
ikovalyov
reviewed
Jan 20, 2017
|
|
||
| // Get role object based on role Id from form | ||
| /** @var Role $role */ | ||
| $role = $this->entityManager->find(Role::class, ['roleId' => 2]); |
ikovalyov
reviewed
Jan 20, 2017
| 'placeholder'=>'John Doe' | ||
| ]); | ||
|
|
||
| $form->get('role')->setAttributes([ |
There was a problem hiding this comment.
write it in template instead of using jquery
Author
There was a problem hiding this comment.
did it as it is at native code, so no idea what do You want here
ikovalyov
reviewed
Jan 20, 2017
| 'placeholder'=>'John Doe' | ||
| ]); | ||
|
|
||
| $form->get('role')->setAttributes([ |
Author
There was a problem hiding this comment.
did it as it is at native code, so no idea what do You want here
ikovalyov
reviewed
Jan 20, 2017
| public function getRolesSelector() | ||
| { | ||
| $roles = $this->entityManager->getRepository(Role::class)->findAll(); | ||
| $hydrator = new \Zend\Hydrator\ClassMethods(); |
ikovalyov
reviewed
Jan 20, 2017
| { | ||
| // checking for existing role if editing mode | ||
| $rolecurrent['role_id'] = self::GUEST_ROLE_ID; | ||
| $hydrator = new \Zend\Hydrator\ClassMethods(); |
ikovalyov
reviewed
Jan 23, 2017
| if ($allow=='*') | ||
| return true; // Anyone is allowed to see the page. | ||
| else if ($allow=='@' && $this->authService->hasIdentity()) { | ||
| else if (($allow=='@' || is_array($allow)) && $this->authService->hasIdentity()) { |
There was a problem hiding this comment.
I don't really like the @ behaviour. It cab be easily resolved with "user" role which cover every logged in user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.