FOUR-32745: Prevent stored XSS in user directory - #9019
Open
eiresendez wants to merge 3 commits into
Open
Conversation
Contributor
|
QA server K8S was successfully deployed https://ci-2f0532ef18.engk8s.processmaker.net |
|
Contributor
|
QA server K8S was successfully deployed https://ci-2f0532ef18.engk8s.processmaker.net |
Contributor
Author
|
Hi @gustavobascope could you please do a code review when you have a chance? Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
A low-privilege user can bypass the single-pass profile sanitizer with nested HTML, store executable markup in user profile fields, and trigger it when an authorized user opens
/admin/users.firstname,lastname, ortitlethroughPUT /api/1.0/users/{id}using a nested HTML payload./admin/usersas a user with directory access.Solution
firstname,lastname, andtitleas plain text before persistence.edit-personal-profileand enforce a profile-field allowlist for non-administrative self-service updates.edit-user-and-password.fullnamethrough escaped Vue slots in active and deleted user listings.How to Test
./vendor/bin/phpunit tests/unit/ProcessMaker/Rules/PlainTextTest.php tests/Feature/Api/UsersTest.php tests/Feature/ProfileTest.php.npm run development.422, unauthorized or disallowed self-service updates return403, and valid updates return204.Related Tickets & Packages
ci:deploy