Skip to content

[51659] Texas Bank - Unable to delete and edit an existing auth client#8868

Open
marcoAntonioNina wants to merge 1 commit into
developfrom
bugfix/FOUR-31613
Open

[51659] Texas Bank - Unable to delete and edit an existing auth client#8868
marcoAntonioNina wants to merge 1 commit into
developfrom
bugfix/FOUR-31613

Conversation

@marcoAntonioNina

@marcoAntonioNina marcoAntonioNina commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

The problem was that there was a command in Laravel Passport that tried to find the client with the current user, but it couldn't find it.

Solution

  • Replaced direct client lookup with a new method findActiveClient to improve readability and maintainability.
  • Updated tests to use constants for OAuth client URLs, improving code clarity and reducing duplication.

How to Test

  • create a new client OAuthclient
  • Attempting to edit or delete should have resulted in an error; with the change, it's now possible to edit and delete.

Related Tickets & Packages

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

…oller

- Replaced direct client lookup with a new method `findActiveClient` to improve readability and maintainability.
- Added logging for failed client lookups to aid in debugging.
- Updated tests to use constants for OAuth client URLs, improving code clarity and reducing duplication.
@marcoAntonioNina marcoAntonioNina self-assigned this Jun 15, 2026
@processmaker-sonarqube

Copy link
Copy Markdown

@Kookster310

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://ci-32867626d8.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants