Add Async suffix to async methods#792
Merged
Merged
Conversation
Member
|
out of curiosity... did you automate this change? |
Contributor
Author
|
Heh, semi-automatic. I found all the method signatures missing the There has to be a Visual Studio extension that offers that code fix but I didn't have my Windows/full VS machine with me and there weren't that many things to rename so I went on with that. |
rkeithhill
approved these changes
Nov 13, 2018
Contributor
rkeithhill
left a comment
There was a problem hiding this comment.
I'm pretty sure that is the largest PR I've ever reviewed. :-) LGTM.
rjmholt
approved these changes
Nov 13, 2018
TylerLeonhardt
approved these changes
Nov 13, 2018
Member
TylerLeonhardt
left a comment
There was a problem hiding this comment.
You got comments, abstract classes, not tests.... this PR is great! Thanks for doing this!
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Dec 14, 2018
rjmholt
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Jan 18, 2019
rjmholt
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Jan 18, 2019
[Ignore] no need for package sources (PowerShell#803) [Ignore] add null check for version
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177 in the 2.0.0 branch.
Rename all (hopefully!) async methods with an -
Asyncsuffix