Skip to content

Fix flaky CanRegisterAndInvokeCommandWithScriptBlock on PS 5.1 / net462 #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −7
Open

Fix flaky CanRegisterAndInvokeCommandWithScriptBlock on PS 5.1 / net462 #2307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e82f40f
Initial plan
Copilot Jun 16, 2026
d3cd30a
Fix CanRegisterAndInvokeCommandWithScriptBlock test reliability on PS…
Copilot Jun 16, 2026
4850fe1
Restore value assertion in CanRegisterAndInvokeCommandWithScriptBlock
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions test/PowerShellEditorServices.Test/Extensions/ExtensionCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,23 +93,24 @@ public async Task CanRegisterAndInvokeCommandWithScriptBlock()
const string commandName = "test.scriptblock";
const string commandDisplayName = "ScriptBlock extension";

// Use AddScript so the script block is created in PowerShell's own session state
// rather than C#'s module context. ScriptBlock.Create() binds to the C# module,
// so $global: writes made via Invoke-Command land in an isolated scope on PS 5.1.

@andyleejordan andyleejordan Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know PowerShell well enough to say if this is true; but the test has been flaky, so if the test is now passing, perhaps that's enough?

await psesHost.ExecutePSCommandAsync(
new PSCommand()
.AddCommand("Register-EditorCommand")
.AddParameter("Name", commandName)
.AddParameter("DisplayName", commandDisplayName)
.AddParameter("ScriptBlock", ScriptBlock.Create("$global:extensionValue = 10")),
.AddScript(
$"Register-EditorCommand -Name '{commandName}' -DisplayName \"{commandDisplayName}\" " +
"-ScriptBlock { $global:extensionValue = 10 }"),
CancellationToken.None);

Assert.NotNull(commandAdded);
Assert.Equal(commandName, commandAdded.Name);
Assert.Equal(commandDisplayName, commandAdded.DisplayName);

// Invoke the command.
// TODO: What task was this cancelling?
await extensionCommandService.InvokeCommandAsync("test.scriptblock", editorContext);
await extensionCommandService.InvokeCommandAsync(commandName, editorContext);

// Assert the expected value
// Assert the expected value.
PSCommand psCommand = new PSCommand().AddScript("$global:extensionValue");
IEnumerable<int> results = await psesHost.ExecutePSCommandAsync<int>(psCommand, CancellationToken.None);
Assert.Equal(10, results.FirstOrDefault());
Expand Down
Loading