Fix the TranscribeOnly bug (take two) - #2026
Merged
Andy Jordan (andyleejordan) merged 2 commits intoMay 23, 2023
Merged
Conversation
6 tasks
Patrick Meinecke (SeeminglyScience)
approved these changes
May 17, 2023
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/fix-transcript-bug-take-two
branch
2 times, most recently
from
May 18, 2023 01:38
3d8f00c to
7ba4620
Compare
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/fix-transcript-bug-take-two
branch
from
May 18, 2023 02:25
7ba4620 to
53220a6
Compare
We were using our own UI, not the byzantine internal UI where it actually needed to be fixed. Whole lot of reflection. Also had to fix our `CoreCLR` compiler constant.
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/fix-transcript-bug-take-two
branch
from
May 18, 2023 02:31
53220a6 to
0e17030
Compare
Member
Author
|
P.S. This is actually like take five. |
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
Just some clean up. A normal invocation will be a virtual call so we'll get the override just fine thankfully.
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
Andy Jordan (andyleejordan)
deleted the
andschwa/fix-transcript-bug-take-two
branch
May 23, 2023 00:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using our own UI, not the byzantine internal UI where it actually needed to be fixed.
This is #2023 but again, with the right UI.
And not only have we tracked this down, we were finally able to reproduce it (and so test this fix).
Resolves PowerShell/vscode-powershell#3991.