Skip to content

Update copyright symbol for NuGet packages #9936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit into from
Jun 28, 2019
Merged

Update copyright symbol for NuGet packages #9936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/packaging/packaging.strings.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ open {0}
<licenseUrl>https://github.com/PowerShell/PowerShell/blob/master/LICENSE.txt</licenseUrl>
<tags>PowerShell</tags>
<language>en-US</language>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<copyright>&#169; Microsoft Corporation. All rights reserved.</copyright>

@iSazonov Ilya (iSazonov) Jun 19, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "(c)"? We use in all files:

// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

@daxian-dbw Dongbo Wang (daxian-dbw) Jun 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Maybe we can change to use (c)?

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jun 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NuGet.org documentation needs it this way or the copyright symbol.

@TravisEz13 Travis Plunk (TravisEz13) Jun 20, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, our legal teams says OSS should use (c). I sent Aditya Patwardhan (@adityapatwardhan) the link offline.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jun 28, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with nuget folks, and the only acceptable values are the copyright symbol and ©

<contentFiles>
<files include="**/*" buildAction="None" copyToOutput="true" flatten="false" />
</contentFiles>
Expand Down Expand Up @@ -163,7 +163,7 @@ open {0}
<license type="expression">MIT</license>
<tags>PowerShell</tags>
<language>en-US</language>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<copyright>&#169; Microsoft Corporation. All rights reserved.</copyright>
<packageTypes>
<packageType name="DotnetTool" />
</packageTypes>
Expand Down