Remove code from CI.psm1 to optionally run Feature tests - #9212
Conversation
|
Travis Plunk (@TravisEz13) anything specific you need me to do right now? |
|
Reece Dunham (@RDIL) ... I reviewed the usage of test-dailybuild and corrected the logic. |
|
Thanks |
| One of the following tags must be used: | ||
|
|
||
| * `CI` - this tag indicates that the tests in the `Describe` block will be executed as part of the CI/PR process | ||
| * `Feature` - tests with this tag will not be executed as part of the CI/PR process, but they will be executed on a daily basis as part of a `cron` driven build. |
There was a problem hiding this comment.
actually this should not be deleteed
|
|
||
| * `CI` - this tag indicates that the tests in the `Describe` block will be executed as part of the CI/PR process | ||
| * `Feature` - tests with this tag will not be executed as part of the CI/PR process, but they will be executed on a daily basis as part of a `cron` driven build. | ||
| They indicate that the test will be validating more behavior, or will be using remote network resources (ex: package management tests) |
There was a problem hiding this comment.
This should still be a sub-bullet under feature
|
Reece Dunham (@RDIL): Could you please update the PR title and give more details in the summary and context. Right now it could be interpreted that all Pester tests tagged with |
|
Sure |
|
PoshChan-Bot (@PoshChan) Please remind me in 1 hour |
|
Travis Plunk (@TravisEz13), all requests start with the magic word |
|
PoshChan-Bot (@PoshChan) please remind me in 1 hour |
|
Reece Dunham (@RDIL), I do not understand: please remind me in an hour |
|
Reece Dunham (@RDIL), will remind you in 1 hour |
CI.psm1 to optionally run Feature tests
|
Reece Dunham (@RDIL), this is the reminder you requested 1 hour ago |
|
Travis Plunk (@TravisEz13) this is the reminder you requested an hour ago |
PR Summary
Makes feature tests run without the tag (which now causes issues)
PR Context
Travis Plunk (@TravisEz13) said this needed to be done
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.