Skip to content

Make Start-Job throw terminating exception when -RunAs32 is specified in 64-bit pwsh#9143

Merged
adityapatwardhan merged 2 commits into
PowerShell:masterfrom
daxian-dbw:runas32
Mar 18, 2019
Merged

Make Start-Job throw terminating exception when -RunAs32 is specified in 64-bit pwsh#9143
adityapatwardhan merged 2 commits into
PowerShell:masterfrom
daxian-dbw:runas32

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented Mar 15, 2019 •
edited by adityapatwardhan
Loading

Copy link
Copy Markdown
Member

PR Summary

Make Start-Job throw terminating exception when -RunAs32 is specified in 64-bit pwsh.
To start a 32-bit pwsh, you need to have the 32-bit pwsh installed.

PR Context

PR Checklist

@daxian-dbw daxian-dbw requested review from SteveL-MSFT and adityapatwardhan and removed request for BrucePay and mirichmo March 15, 2019 06:52
@daxian-dbw daxian-dbw added Area-Maintainers-Documentation specific to documentation in this repo Documentation Needed in this repo Documentation is needed in this repo CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Area-Maintainers-Documentation specific to documentation in this repo labels Mar 15, 2019
@adityapatwardhan

adityapatwardhan commented Mar 15, 2019

Copy link
Copy Markdown
Member

@daxian-dbw Can you file the bug for documentation?
Did you test the code change on a 32 bit build? We do not run 32 bit in CI.

@daxian-dbw

daxian-dbw commented Mar 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Did you test the code change on a 32 bit build? We do not run 32 bit in CI.

Yes, I tested manually on a 32 bit build.

Can you file the bug for documentation?

Yes, done: MicrosoftDocs/PowerShell-Docs#4003

@daxian-dbw daxian-dbw mentioned this pull request Mar 15, 2019
Closed
8 tasks
@adityapatwardhan

adityapatwardhan commented Mar 16, 2019

Copy link
Copy Markdown
Member

Updated the PR template with the link to the doc issue.

@adityapatwardhan

adityapatwardhan commented Mar 16, 2019

Copy link
Copy Markdown
Member

@PoshChan remind me in 65 hours

@PoshChan

PoshChan commented Mar 16, 2019

Copy link
Copy Markdown
Collaborator

@adityapatwardhan, I do not understand: remind me in 65 hours

@adityapatwardhan

adityapatwardhan commented Mar 16, 2019

Copy link
Copy Markdown
Member

@PoshChan Please remind me in 65 hours

@PoshChan

PoshChan commented Mar 16, 2019

Copy link
Copy Markdown
Collaborator

@adityapatwardhan, will remind you in 65 hours

@vexx32

vexx32 commented Mar 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Oh my gosh @SteveL-MSFT you made it to expect to be asked nicely?

That's fantastic! 😂

@SteveL-MSFT

SteveL-MSFT commented Mar 18, 2019

Copy link
Copy Markdown
Member

@vexx32 Of course!

@PoshChan

PoshChan commented Mar 18, 2019

Copy link
Copy Markdown
Collaborator

@adityapatwardhan, this is the reminder you requested 65 hours ago

@adityapatwardhan adityapatwardhan merged commit 24d3152 into PowerShell:master Mar 18, 2019
@daxian-dbw daxian-dbw deleted the runas32 branch March 18, 2019 17:26
@rurusasu rurusasu mentioned this pull request May 16, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daxian-dbw @adityapatwardhan @PoshChan @vexx32 @SteveL-MSFT