-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Move Final artifacts from universal build to finalResults folder
#8806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TravisEz13
merged 13 commits into
PowerShell:master
from
TravisEz13:make_artifiacts_similar_v2_gh
Feb 1, 2019
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f3e3465
rename template per previous RP feedback
TravisEz13 d6cb950
update destination of artifacts
TravisEz13 f6c0027
make condition a parameter
TravisEz13 a64d6cc
fix typo in template
TravisEz13 8f67248
Silently Continue when nothing is found
TravisEz13 503a555
Switch to deployment sprites
TravisEz13 1a1ee42
update diagram
TravisEz13 5ee204f
Update readme.md
TravisEz13 2adfc65
move things into folders to reduce duplicate text
TravisEz13 6af0752
remove comments and make final adjustments
TravisEz13 7acb3ca
add an SVG preview extension
TravisEz13 85baef4
Switch to SVG
TravisEz13 383af6a
increase timeout for APIScan
TravisEz13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,55 @@ | ||
| # VSTS Release Builds | ||
| # Azure Dev Ops Release Builds | ||
|
|
||
| ## Requirements | ||
|
|
||
| Docker must be installed to run any of the release builds. | ||
|
|
||
| ## Running Windows Release Builds | ||
| ## Running Windows Release Builds Locally | ||
|
|
||
| From PowerShell on Windows, run `.\vstsbuild.ps1 -ReleaseTag <tag> -Name <buildName>`. | ||
|
|
||
| Windows Build Names: | ||
| For the package builds, run `.\vstsbuild.ps1 -ReleaseTag <tag> -Name <buildName> -BuildPath <path to extracted zip from build step> -SignedFilesPath <path to extracted 'symbol' zip from build step>` | ||
|
|
||
| * `win7-x64` | ||
| * Builds the Universal Windows x64 Package | ||
| * `win7-x86` | ||
| * Builds the Universal Windows x86 Package | ||
| * `win7-x64-symbols` | ||
| * Builds the Windows x64 Zip with symbols | ||
| * `win7-x86-symbols` | ||
| * Builds the Windows x86 Zip with symbols | ||
| Windows Build Names: | ||
|
|
||
| ## Running Linux Release Builds | ||
| * `win7-x64-symbols` | ||
| * Builds the Windows x64 Zip with symbols | ||
| * `win7-x86-symbols` | ||
| * Builds the Windows x86 Zip with symbols | ||
| * `win7-arm-symbols` | ||
| * Builds the Windows ARM Zip with symbols | ||
| * `win7-arm64-symbols` | ||
| * Builds the Windows ARM64 Zip with symbols | ||
| * `win7-fxdependent-symbols` | ||
| * Builds the Windows FxDependent Zip with symbols | ||
| * `win7-x64-package` | ||
| * Builds the Windows x64 packages | ||
| * `win7-x86-package` | ||
| * Builds the Windows x86 packages | ||
| * `win7-arm-package` | ||
| * Builds the Windows ARM packages | ||
| * `win7-arm64-package` | ||
| * Builds the Windows ARM64 packages | ||
| * `win7-fxdependent-package` | ||
| * Builds the Windows FxDependent packages | ||
|
|
||
| ## Running Linux Release Builds Locally | ||
|
|
||
| From PowerShell on Linux or macOS, run `.\vstsbuild.ps1 -ReleaseTag <tag> -Name <buildName>`. | ||
|
|
||
| Linux Build Names: | ||
|
|
||
| * `ubuntu.14.04` | ||
| * Builds the Ubuntu 14.04 Package and AppImage Package | ||
| * `ubuntu.16.04` | ||
| * Builds the Ubuntu 16.04 Package | ||
| * `centos.7` | ||
| * Builds the CentOS 7 Package | ||
| * `deb` | ||
| * Builds the Debian Packages, ARM32 and ARM64. | ||
| * `alpine` | ||
| * Builds the Alpine Package | ||
| * `rpm` | ||
| * Builds the RedHat variant Package | ||
|
|
||
| ## Azure Dev Ops Build | ||
|
|
||
| The release build is fairly complicated. The definition is at `./azureDevOps/releaseBuild.yml`. | ||
|
|
||
| Here is a diagram of the build: | ||
|
|
||
| [](https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/releaseBuild/azureDevOps/diagram.svg?sanitize=true) |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
tools/releaseBuild/azureDevOps/templates/upload-final-results.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| parameters: | ||
| artifactPath: | ||
| artifactFilter: '*' | ||
| condition: succeeded() | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add a parameter for container name to make this task more general and default it to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change can be made later. |
||
|
|
||
| steps: | ||
| - powershell: | | ||
| Get-ChildItem -Path '${{ parameters.artifactPath }}' -File -filter '${{ parameters.artifactFilter }}' -ErrorAction SilentlyContinue | | ||
| Select-Object -ExpandProperty FullName | | ||
| ForEach-Object { | ||
| Write-Host "##vso[artifact.upload containerfolder=finalResults;artifactname=finalResults]$_" | ||
| } | ||
| displayName: Upload Final Artifacts ${{ parameters.artifactFilter }} from ${{ parameters.artifactPath }} | ||
| condition: ${{ parameters.condition }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want
succeeded()orfailOrSucceeded()? Maybe we should be able to upload whatever artifacts were built.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think about retry scenarios. We don't want to leave this folder potentially polluted.