Skip to content

Improve check for developer mode by checking minimum required build number #8749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Travis Plunk (TravisEz13) merged 5 commits into from
Jan 25, 2019
Merged

Improve check for developer mode by checking minimum required build number #8749

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
961d585
Improve check for developer mode by checking minimum required build n…
adityapatwardhan Jan 25, 2019
9bd7dec
Update test/powershell/Modules/Microsoft.PowerShell.Management/New-It…
JamesWTruher Jan 25, 2019
2caa9c2
Fix check in product so 10.1.0 OSVersion does not fail to add the flag
adityapatwardhan Jan 25, 2019
c7c4f98
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
adityapatwardhan Jan 25, 2019
1d9050a
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
adityapatwardhan Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve check for developer mode by checking minimum required build n… 
…umber

The test would fail if the developer mode is enabled but the machine has an older build than the minimum required build.
The change adds a check for the build version in the test.
  • Loading branch information
@adityapatwardhan
adityapatwardhan committed Jan 25, 2019
commit 961d585ffb82d8b592abedba60bb90322cee049e
4 changes: 3 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,9 @@ Describe "New-Item with links fails for non elevated user if developer mode not
$testlink = "testlink"
$FullyQualifiedFile = Join-Path -Path $TestDrive -ChildPath $testfile
$TestFilePath = Join-Path -Path $TestDrive -ChildPath $testlink
$developerMode = (Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock -ErrorAction SilentlyContinue).AllowDevelopmentWithoutDevLicense -eq 1
$developerModeEnabled = (Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock -ErrorAction SilentlyContinue).AllowDevelopmentWithoutDevLicense -eq 1
$minBuildRequired = ([System.Environment]::OSVersion.Version.Major -eq 10 -and [System.Environment]::OSVersion.Version.Build -ge 14972) -or ([System.Environment]::OSVersion.Version.Major -ge 11)
Comment thread
adityapatwardhan marked this conversation as resolved.
Outdated
$developerMode = $developerModeEnabled -and $minBuildRequired
}

AfterEach {
Expand Down