Skip to content

Revise use of Start-Sleep cmdlet #8633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jan 15, 2019
Merged

Revise use of Start-Sleep cmdlet #8633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/docker/networktest/DockerRemoting.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ Describe "Basic remoting test with docker" -tags @("Scenario","Slow"){

# give the containers something to do, otherwise they will exit and be removed
Write-Verbose -verbose "setting up docker container PowerShell server"
$server = docker run -d $imageName powershell -c start-sleep $timeout
$server = docker run -d $imageName powershell -c Start-Sleep -Seconds $timeout
Write-Verbose -verbose "setting up docker container PowerShell client"
$client = docker run -d $imageName powershell -c start-sleep $timeout
$client = docker run -d $imageName powershell -c Start-Sleep -Seconds $timeout

# get fullpath to installed core powershell
Write-Verbose -verbose "Getting path to PowerShell core"
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/Language/Classes/Scripting.Classes.Attributes.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ Describe 'ValidateSet support a dynamically generated set' -Tag "CI" {
It 'Can implement CachedValidValuesGeneratorBase with cache expiration in PowerShell' {
Get-TestValidateSetPS5 -Param1 "TestString1" -ErrorAction SilentlyContinue | Should -BeExactly "TestString1"
Get-TestValidateSetPS5 -Param1 "TestString1" -ErrorAction SilentlyContinue | Should -BeExactly "TestString1"
Start-Sleep 3
Start-Sleep -Seconds 3
Get-TestValidateSetPS5 -Param1 "TestString2" -ErrorAction SilentlyContinue | Should -BeExactly "TestString2"
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/powershell/Modules/Microsoft.PowerShell.Core/Job.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Describe "Job Cmdlet Tests" -Tag "CI" {
}
Context "jobs which take time" {
BeforeEach {
$j = Start-Job -ScriptBlock { Start-Sleep 15 }
$j = Start-Job -ScriptBlock { Start-Sleep -Seconds 15 }
}
AfterEach {
Get-Job | Remove-Job -Force
Expand Down Expand Up @@ -93,7 +93,7 @@ Describe "Job Cmdlet Tests" -Tag "CI" {
throw "Receive-Job behaves suspiciously: Cannot receive $n results in 5 minutes."
}

# sleep for 300 ms to allow data to be produced
# Wait to allow data to be produced
Start-Sleep -Milliseconds 300

if ($keep)
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Utility/Implicit.Remoting.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,7 +1947,7 @@ try
Disconnect-PSSession $session
Start-Process powershell -arg 'Get-PSSession -cn localhost -name Session102 | Connect-PSSession' -Wait

Start-Sleep 3
Start-Sleep -Seconds 3

## This time a new session is created because the old one is unavailable.
$dSessionPid = Get-RemoteVariable pid
Expand Down
4 changes: 2 additions & 2 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/XMLCommand.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@ Describe "XmlCommand DRT basic functionality Tests" -Tags "CI" {
$ps = [PowerShell]::Create()
$null = $ps.AddScript("1..10")
$null = $ps.AddCommand("foreach-object")
$null = $ps.AddParameter("Process", { $_; start-sleep 1 })
$null = $ps.AddParameter("Process", { $_; Start-Sleep -Seconds 1 })
$null = $ps.AddCommand("Export-CliXml")
$null = $ps.AddParameter("Path", $testfile)
$null = $ps.BeginInvoke()
Start-Sleep 1
Start-Sleep -Seconds 1
$null = $ps.Stop()
$ps.InvocationStateInfo.State | Should -Be "Stopped"
$ps.Dispose()
Expand Down
2 changes: 1 addition & 1 deletion test/tools/Modules/HelpersCommon/HelpersCommon.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function Wait-UntilTrue
if (([DateTime]::Now - $startTime).TotalMilliseconds -gt $timeoutInMilliseconds) {
return $false
}
# Sleep for the specified interval
# Wait
Start-Sleep -Milliseconds $intervalInMilliseconds
}
return $true
Expand Down
2 changes: 1 addition & 1 deletion test/tools/Modules/HttpListener/HttpListener.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ Function Start-HTTPListener {
{
# ignore if listener is not ready
}
Start-Sleep -milliseconds 100
Start-Sleep -Milliseconds 100
}
if (!$succeeded)
{
Expand Down
4 changes: 2 additions & 2 deletions test/tools/Modules/PSSysLog/PSSysLog.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ function Wait-UntilSuccess
}
}

# Sleep for the specified interval
# Wait
Start-Sleep -Milliseconds $intervalInMilliseconds
}
return $true
Expand Down Expand Up @@ -1073,7 +1073,7 @@ function Wait-PSWinEvent

    do
    {
        sleep $pause
        Start-Sleep -Seconds $pause

$recordsToReturn = @()

Expand Down