Use https in URLs where available by xtqqczze · Pull Request #8622 · PowerShell/PowerShell

xtqqczze · 2019-01-11T12:27:30Z

PR Summary

Use https in URLS across the repository where the domain serves content by https.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
Testing - New and feature
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Ilya (iSazonov) · 2019-01-11T12:41:58Z

How can we really check that all the links work?

Rain Sallow (/u/ta11ow) (vexx32) · 2019-01-11T13:11:16Z

Ilya (@iSazonov) if I recall correctly a recent PR added link verifications to the CI-static-analysis check.

Ilya (iSazonov) · 2019-01-11T13:46:05Z

Rain Sallow (/u/ta11ow) (@vexx32) There is only md-file check.

mdspell '**/*.md' '!**/Pester/**/*.md'

Reece Dunham (RDIL) · 2019-01-11T14:10:28Z

idea stolen from me haha

Reece Dunham (RDIL) · 2019-01-11T14:11:09Z

Ilya (@iSazonov) no you are wrong and Rain Sallow (/u/ta11ow) (@vexx32) is right, I added a link check task but it is only for markdown files.

Reece Dunham (RDIL)

Looks good to me, somebody needs to look over the static analysis logs however.

Reece Dunham (RDIL) · 2019-01-15T14:22:45Z

2019-01-12T17:16:07.6158436Z __UNELEVATED_TESTS_THE_END__
2019-01-12T17:16:08.2464998Z 1 tests in test/powershell failed
2019-01-12T17:16:08.2465114Z At D:\a\1\s\build.psm1:1348 char:13
2019-01-12T17:16:08.2465163Z +             throw "$($x.'test-results'.failures) tests in $TestArea f ...
2019-01-12T17:16:08.2465227Z +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-12T17:16:08.2465281Z     + CategoryInfo          : OperationStopped: (1 tests in test/powershell failed:String) [], RuntimeException
2019-01-12T17:16:08.2465330Z     + FullyQualifiedErrorId : 1 tests in test/powershell failed
2019-01-12T17:16:08.2465801Z  
2019-01-12T17:16:08.2465857Z Upload CoreCLR Non-Admin test results
2019-01-12T17:16:08.2465917Z WARNING: Not running in appveyor, skipping upload of test results: D:\a\1\s\TestsResultsNonAdmin.xml
2019-01-12T17:16:08.2466187Z TEST FAILURES
2019-01-12T17:16:08.2466242Z Description: Should match native commands
2019-01-12T17:16:08.2466300Z Name:        Get-Command CI tests.-UseFuzzyMatch tests.Should match native commands
2019-01-12T17:16:08.2466363Z message:
2019-01-12T17:16:08.2466427Z Expected 'PING.EXE' to be found in collection @('gin', 'gin', 'gin', 'pfn', 'dir', 'popd', 'pushd', 'cpi', 'gi', 'iex'), but it was not found.
2019-01-12T17:16:08.2466485Z stack-trace:
2019-01-12T17:16:08.2466561Z at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Utility\Get-Command.Tests.ps1: line 20
2019-01-12T17:16:08.2466620Z 20:             $cmds.Name | Should -Contain $ping
2019-01-12T17:16:08.2540098Z ##[error]PowerShell exited with code '1'.

Ilya (iSazonov) · 2019-01-15T14:27:25Z

Reece Dunham (@RDIL) Please rebase to pass CIs.

Reece Dunham (RDIL) · 2019-01-15T14:28:57Z

Ilya (@iSazonov) this isn't my PR, just saying what the error message is. 🔨

Ilya (iSazonov) · 2019-01-15T14:50:58Z

Sorry.
xtqqczze Please rebase to pass CIs.

Revert change to Unicode license in `assets\AppImageThirdPartyNotices.txt`

Travis Plunk (TravisEz13) · 2019-01-24T20:50:23Z

Thanks for your contribution

Use https in URLS across the repository where the domain serves content by https.

xtqqczze requested review from Bruce Payette (BrucePay), James Truher (JamesWTruher), Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dongbo Wang (daxian-dbw) and Joey Aiello (joeyaiello) as code owners January 11, 2019 12:27

Ilya (iSazonov) reviewed Jan 11, 2019

View reviewed changes

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 11, 2019

Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Jan 11, 2019

Reece Dunham (RDIL) approved these changes Jan 11, 2019

View reviewed changes

xtqqczze added 9 commits January 15, 2019 16:37

Use https for aka.ms domain

9e5eb34

Use https for go.microsoft.com domain

b844a0b

Use https for github.com domain

4882899

Use https for blogs.msdn.com domain

1f9b5bd

Use https for brew.sh domain

9c5c832

Use https for www.apache.org domain

d6230cd

Use https for ss64.com domain

161c26f

Use https for stackoverflow.com domain

f2e0c3b

Use https for tbaggery.com domain

bfd30de

xtqqczze added 10 commits January 15, 2019 16:37

Use https for opensource.org domain

e4e7edd

Use https for windowsitpro.com domain

db94f49

Use https for www.computerperformance.co.uk domain

0d88eb7

Use https for examples.oreilly.com domain

d0bd43c

Use https for www.opengroup.org domain

fcca6c7

Use https for appimage.org domain

85d010d

Use https for cgit.freedesktop.org domain

87c647b

Use https for www.nuget.org domain

6275bb7

Use https for specifications.freedesktop.org domain

e3eb84f

Use https for www.bing.com domain

ba47ebc

xtqqczze force-pushed the https branch from 922ad27 to ba47ebc Compare January 15, 2019 16:40

Merge branch 'master' into https

83c2328

Travis Plunk (TravisEz13) reviewed Jan 16, 2019

View reviewed changes

Comment thread assets/license.rtf

Travis Plunk (TravisEz13) reviewed Jan 16, 2019

View reviewed changes

Comment thread ThirdPartyNotices.txt

Travis Plunk (TravisEz13) reviewed Jan 16, 2019

View reviewed changes

Comment thread assets/AppImageThirdPartyNotices.txt Outdated

Travis Plunk (TravisEz13) reviewed Jan 16, 2019

View reviewed changes

Comment thread assets/additionalAttributions.txt Outdated

xtqqczze mentioned this pull request Jan 18, 2019

Remove broken HelpUri from CimTest #8688

Merged

8 tasks

xtqqczze added 2 commits January 18, 2019 18:52

Merge branch 'master' into https

01f8f79

Revert change to \AppImageThirdPartyNotices.txt

b04043c

Revert change to Unicode license in `assets\AppImageThirdPartyNotices.txt`

xtqqczze force-pushed the https branch from 56398a9 to 1e6583c Compare January 18, 2019 21:19

xtqqczze added 3 commits January 18, 2019 21:23

Revert change to ThirdPartyNotices.txt

a4ead61

Merge branch 'master' into https

f863815

[Feature] Empty commit for CI

5823c0a

xtqqczze force-pushed the https branch from 1e6583c to 5823c0a Compare January 18, 2019 21:23

Merge branch 'master' into https

c2c973e

Travis Plunk (TravisEz13) approved these changes Jan 24, 2019

View reviewed changes

Travis Plunk (TravisEz13) merged commit 8635288 into PowerShell:master Jan 24, 2019

xtqqczze deleted the https branch February 1, 2019 00:21

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Use https in URLs where available (PowerShell#8622)

f9d639e

Use https in URLS across the repository where the domain serves content by https.

Uh oh!

Conversation

xtqqczze commented Jan 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jan 11, 2019

Uh oh!

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 11, 2019

Uh oh!

Ilya (iSazonov) commented Jan 11, 2019

Uh oh!

Reece Dunham (RDIL) commented Jan 11, 2019

Uh oh!

Reece Dunham (RDIL) commented Jan 11, 2019

Uh oh!

Reece Dunham (RDIL) left a comment

Choose a reason for hiding this comment

Uh oh!

Reece Dunham (RDIL) commented Jan 15, 2019

Uh oh!

Ilya (iSazonov) commented Jan 15, 2019

Uh oh!

Reece Dunham (RDIL) commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jan 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) commented Jan 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xtqqczze commented Jan 11, 2019 •

edited

Loading

Reece Dunham (RDIL) commented Jan 15, 2019 •

edited

Loading