Update folder path for storing optimization profile and add test to validate loaded assemblies and libraries on startup - #8406
Merged
Dongbo Wang (daxian-dbw) merged 7 commits intoDec 6, 2018
Conversation
Dongbo Wang (daxian-dbw)
requested review from
Steve Lee (SteveL-MSFT),
Aditya Patwardhan (adityapatwardhan) and
Andrew (anmenaga)
December 6, 2018 02:22
Dongbo Wang (daxian-dbw)
requested a review
from Bruce Payette (BrucePay)
as a code owner
December 6, 2018 02:22
11 tasks
Steve Lee (SteveL-MSFT)
requested changes
Dec 6, 2018
Member
|
Steve Lee (@SteveL-MSFT) Please update your review. |
Steve Lee (SteveL-MSFT)
approved these changes
Dec 6, 2018
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
…alidate loaded assemblies and libraries on startup (PowerShell#8406) - Update folder path for storing optimization profile file. - Add test to validate loaded assemblies and libraries on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Two changes in this PR:
Assemblies loaded on startup impact startup time. Sometimes we merge a commit that uses a new type that adds loading a new assembly on startup. We need to catch these and decide if it's worth the impact or delay loading when possible.
Assemblies that are loaded during startup are affected by the profile optimization automatically generated in powershell. The
StartupProfileData-xxxxfiles record assemblies that are potentially used right after powershell starts. With such a file being available, powershell will eagerly load those assemblies using multiple CPU cores, even though some assemblies are not really needed for the current use case.So, to accurately test the loaded assemblies at startup, we need to remove
StartupProfileData-NonInteractivebefore runpwsh -noprofile -command ...PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests