Skip to content

Adding verbose output for experimental implicit remoting batching feature - #8166

Merged
Aditya Patwardhan (adityapatwardhan) merged 7 commits into
PowerShell:masterfrom
PaulHigin:UpdateImplicitRemotingBatching
Nov 5, 2018
Merged

Adding verbose output for experimental implicit remoting batching feature#8166
Aditya Patwardhan (adityapatwardhan) merged 7 commits into
PowerShell:masterfrom
PaulHigin:UpdateImplicitRemotingBatching

Conversation

@PaulHigin

Copy link
Copy Markdown
Contributor

PR Summary

This change adds verbose output to the experimental implicit remoting batching feature, that provides information about whether the command line was batch-able for implicit remoting. If it is not batch-able then the reason why is provided. This is intended to help learn why a pipeline could not be batched and help address batching scenarios that should be covered.

Example:

$s = New-PSSession -host testVM -KeyFilePath -User paul
Invoke-Command $s { Import-PSSession 'c:\Modules\TestIMod\TestIMod.psd1' }
Import-PSSession $s -module TestIMod

$maxProcs = 1000
$filter = 'pwsh','powershell*'

$VerbosePreference = "Continue"

Get-AllProcesses -MaxCount $maxProcs | Select-Custom $filter | ForEach-Object { $_ }
VERBOSE: Implicit remoting command pipeline has been batched for execution on remote target.

NPM(K)    PM(M)      WS(M)     CPU(s)      Id  SI ProcessName
 ------    -----      -----     ------      --  -- -----------
     60   291.51     140.08     226.92   15184   2 powershell
     54   129.84     109.26     370.78   15832   2 powershell
     57    69.21      92.28      13.86     168   0 pwsh

100 | Get-AllProcesses -MaxCount $maxProcs | Select-Custom $filter | ForEach-Object { $_ }
VERBOSE: Command pipeline not supported for implicit remoting batching. : PipelineStartingWithExpressionNotSupported

NPM(K)    PM(M)      WS(M)     CPU(s)      Id  SI ProcessName
 ------    -----      -----     ------      --  -- -----------
     61   291.54     140.09     226.92   15184   2 powershell
     54   129.84     109.26     370.88   15832   2 powershell
     57    69.72      92.86      17.81     168   0 pwsh

PR Checklist

@PaulHigin

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Can you review this change?

Comment thread src/System.Management.Automation/resources/ParserStrings.resx Outdated
Comment thread src/System.Management.Automation/resources/ParserStrings.resx Outdated
Comment thread src/System.Management.Automation/resources/ParserStrings.resx
@SteveL-MSFT Steve Lee (SteveL-MSFT) removed this from the 6.1.x-servicing milestone Nov 1, 2018
Comment thread src/System.Management.Automation/resources/ParserStrings.resx Outdated
@adityapatwardhan

Copy link
Copy Markdown
Member

The CI seems to be stuck. I will close and re-open the PR for restarting it.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit acf5eb5 into PowerShell:master Nov 5, 2018
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the UpdateImplicitRemotingBatching branch November 6, 2018 00:10
@iSazonov Ilya (iSazonov) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants