Skip to content

fix the "Basic cookbooks" link - #7934

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
vmsilvamolina:patch-1
Oct 10, 2018
Merged

fix the "Basic cookbooks" link#7934
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
vmsilvamolina:patch-1

Conversation

@vmsilvamolina

@vmsilvamolina Victor Silva (vmsilvamolina) commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

PR Summary

I found a mistake on the PowerShell Web Docs: Basic cookbooks link, but searching on the documentation, the only link that mention "cookbook", is the suggested.

PR Checklist

I found a mistake on the PowerShell Web Docs: Basic cookbooks link, but searching on the documentation, the only link that mention "cookbook is the suggested. It's right? Is any file missing?
@vmsilvamolina

Copy link
Copy Markdown
Contributor Author

It's right? Is any file missing?

Comment thread docs/learning-powershell/README.md Outdated
- Microsoft Virtual Academy: [Getting Started with PowerShell][getstarted-with-powershell]
- [Why Learn PowerShell][why-learn-powershell] by Ed Wilson
- PowerShell Web Docs: [Basic cookbooks][basic-cookbooks]
- PowerShell Web Docs: [Basic cookbooks][https://docs.microsoft.com/en-us/powershell/scripting/getting-started/fundamental/sample-scripts-for-administration?view=powershell-6]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the file pattern and move the url to eof (add [basic-cookbooks]:url).

@iSazonov

Copy link
Copy Markdown
Collaborator

Appveyor CI temporary failed.

@vmsilvamolina

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) how can I help to solve the AppVeyor error?

@SteveL-MSFT

Copy link
Copy Markdown
Member

Victor Silva (@vmsilvamolina) I restarted build on AppVeyor as it's not related to your changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13

Copy link
Copy Markdown
Member

I had to restart AppVeyor again. Ping me if I don't update the PR within a day.

@anmenaga

Copy link
Copy Markdown

Travis Plunk (@TravisEz13) This looks ready for merge.

@TravisEz13
Travis Plunk (TravisEz13) merged commit 5601470 into PowerShell:master Oct 10, 2018
@iSazonov

Copy link
Copy Markdown
Collaborator

Victor Silva (@vmsilvamolina) Thanks for your contribution!

Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants