Remove WriteVerbose statement from ConvertTo-Json - #7487
Remove WriteVerbose statement from ConvertTo-Json#7487Dongbo Wang (daxian-dbw) merged 2 commits into
Conversation
|
Brandon Olin (@devblackops) I wonder do you see the verbose messages without |
There was a problem hiding this comment.
Brandon Olin (@devblackops) Please also remove the message string which would no longer be used after this pr:
|
Ilya (@iSazonov) The messages aren't shown without It's easy enough to suppress the verbose output with |
|
Mark Kraus (@markekraus) I pushed a commit to remove the resource string. |
Dan Travison (dantraMSFT)
left a comment
There was a problem hiding this comment.
I agree the verbose statement doesn't add much value.
It was added when StopProcessing was added so I expect it was done for debugging purposes.
|
Brandon Olin (@devblackops) Thanks for your contribution! |
…erShell#7487)" This reverts commit 8374a5c.
PR Summary
Fix #7486.
In PR #6392, a
WriteVerbosestatement was added toConvertTo-Jsonwhich I feel is unnecessary. On large or complex objects being serialized to json, this produces a ton of verbose messages which isn't adding any value to the end user. This PR removes that statement.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests