Revert change to have SetLocation() treat wildcarded path as literal if it exists - #7101
Merged
Merged
Conversation
Collaborator
|
I wonder that Travis CI failed. |
|
Historically, any change in 'namespaces' code has a high-risk of regressions in this high-traffic code path. |
SteveL-MSFT
force-pushed
the
revert-setlocation
branch
2 times, most recently
from
June 18, 2018 23:19
87ee2bb to
133e7ad
Compare
Member
Author
|
The test failure appears to be a symptom of #7032 |
Collaborator
|
@SteveL-MSFT We have a fix #7033 |
Revert "Set-Location should use path with wildcard characters if it exists instead of globbing (PowerShell#5839)" This reverts commit 7459b54.
SteveL-MSFT
force-pushed
the
revert-setlocation
branch
from
June 25, 2018 20:08
133e7ad to
7533ba9
Compare
Member
Author
rjmholt
approved these changes
Jun 26, 2018
Member
|
@iSazonov merged commit didn't have a description. |
Collaborator
|
@TravisEz13 The commit has a description but multi-line - sorry that I missed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This reverts commit 7459b54.
Left the added tests as
Pending.Fix #6927
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests